On Thu, Jun 30, 2016 at 03:53:21PM +0200, Philippe Guibert wrote: > On Thu, Jun 30, 2016 at 9:57 AM, David Lamparter > <da...@opensourcerouting.org> wrote: > > Hello David, > > > I have a rebased/somewhat-cleaned version around, might be more useful > > to look at that. It's not fully cleaned up yet, but better than what's > > currently up there. I'll push it out some time today, will send another > > email. (Actually started writing docs for capnp...) > > Thanks for your work effort you actually did for the rebase & the cleaning. > I am volonteer to make a review once you make it available. > > I guess the rebase is starting from ff/8 branch ? > I realized that the patch series 1822 till 1831 had to be reworked too > ( I was about to push it again ;)).
I haven't moved to ff/8 yet, it's origin/master as it was a few weeks back. It does have the "memtypes" series in its history; I've rebased that about 10 times now already, it's not that big of a deal ;) > > However - the BGP VRF stuff is probably deprecated by either Lou's work, > > or Cumulus's work, or both. I would suggest to look at their stuff... > > From what I looked, the multiple label per NLRI is not yet in BGP VRF > feature from quagga upstream, and conflicts. > > > P.S.: the cap'n proto codegenerator is unfortunately still not public :/ > > Could you be more specific about it ? There are several components to the Cap'n Proto interface: - capnpc, the .capnp schema language parser/translator - libcapnproto-c, utility library + "classic" C code generator - Quagga code changes + schema files - quaxolotl-capngc, the "advanced" C code generator - quaxolotl-client, the python demo/reference client Of these, quaxolotl-capngc is not public. It's a relatively complex python tool to translate .capnp + .ndef files into C code. (4400 LoC) What that means is that when I commit the generated .c files, everything works as intended, but you can't change the schema and regenerate -- the tool for that will be missing. > As far as I know, capnproto is not available for all platforms ( need > recent gcc compiler?). I don't think libcapnproto-c has special compiler requirements; neither does the capnproto Quagga code. The Quagga code does need a gcc-compatible compiler (__attribute__), but all neccessary features have been available on gcc, clang and icc for a long time. NB: the capnproto Quagga interface does NOT use the capnproto C++ library. It still needs capnpc (which is bundled with the C++ stuff), but the result is all pure C. Cheers, -David _______________________________________________ Quagga-dev mailing list Quagga-dev@lists.quagga.net https://lists.quagga.net/mailman/listinfo/quagga-dev
