Paul,
I’ve started it, but already found some BGP issues…
So somehow my CI testbed had a bug and when the basic setup of the BGP
IPv6 tests failed (and caused all tests to skip),
then this was ignored (skipped instead of failed tests). Sorry :-(
This broke with the CI Pull Request #38 (and was fine up to and
including #37)
https://github.com/opensourcerouting/quagga/pull/38
Should have been flagged as failed and not as good…
The issue (on IPv6 BGP):
“No supported <AFI, SAFI> combination found in the received BGP4 Open
Message”
This works for plain IPv4 BGP, but fails for IPv6 sessions.
Additionally, for AS4 BGP sessions (IPv4 or IPv6), there is a collision
issue which then closes the session:
(I thought you fixed this - did the fix only apply to 2-byte AS?)
From the bgpd log for the collision:
2016/09/13 18:41:04 BGP: [Event] Make dummy peer structure until read
Open packet
2016/09/13 18:41:04 BGP: 192.168.1.1 [FSM] TCP_connection_open
(Active->OpenSent)
2016/09/13 18:41:04 BGP: 192.168.1.1 passive open
2016/09/13 18:41:04 BGP: 192.168.1.1 sending OPEN, version 4, my as 500,
holdtime 180, id 192.168.1.101
2016/09/13 18:41:04 BGP: 192.168.1.1 send message type 1, length (incl.
header) 51
2016/09/13 18:41:04 BGP: 192.168.1.1 went from Active to OpenSent
2016/09/13 18:41:04 BGP: 192.168.1.1 rcv message type 1, length (excl.
header) 18
2016/09/13 18:41:04 BGP: 192.168.1.1 rcv OPEN, version 4, remote-as (in
open) 23456, holdtime 90, id 192.168.1.1, inbound connection
2016/09/13 18:41:04 BGP: 192.168.1.1 [AS4] rcv OPEN w/ OPTION parameter
len: 8, peeking for as4
2016/09/13 18:41:04 BGP: [AS4] found AS4 capability, about to parse
2016/09/13 18:41:04 BGP: 192.168.1.1 [AS4] about to set cap
PEER_CAP_AS4_RCV, got as4 65538
2016/09/13 18:41:04 BGP: %NOTIFICATION: sent to neighbor 192.168.1.1 6/7
(Cease/Connection collision resolution) 0 bytes
2016/09/13 18:41:04 BGP: 192.168.1.1 send message type 3, length (incl.
header) 21
2016/09/13 18:41:04 BGP: Notification sent to neighbor 192.168.1.1: type
6/7
Let me know if you need help to reproduce the issues
- Martin
On 13 Sep 2016, at 2:54, p...@jakma.org wrote:
Hi Martin,
I've got a head of commits that pass your CI (tested via the
auto-merge feature) at:
http://git.savannah.gnu.org/cgit/quagga.git/log/?h=volatile/patch-tracking/8/proposed/ff-2016091301
It's 173 commits odd. Including a CVE fix for an issue with MRT
dumping that can lead to an ABRT.
I believe you wanted to do a final full compliance run, before
integration to master. After which we can do a release, and attack the
next set of patches (which may also be a larger set than ideal, cause
of the length of r8, but still more manageable - so we should converge
on a more sane, faster turn-around on these soon).
regards,
--
Paul Jakma | p...@jakma.org | @pjakma | Key ID: 0xD86BF79464A2FF6A
Fortune:
Make sure every module hides something.
- The Elements of Programming Style (Kernighan & Plaugher)
_______________________________________________
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev
