Hi Christian,
On 09/14/2010 02:12 PM, cstrato wrote:
Dear Simon,
Thank you for this clarification/suggestion, however I am confused. What
do you mean with "If the file is created automatically then it has no
business being in the package."?
He means it shouldn't be in the source tarball. We run 'R CMD check'
on source trees or source tarballs. Source tarballs are platform
independent. If I understand correctly when you run 'R CMD build'
on your source tree, you use some trick to generate this src/xpsDict.h
file on Windows and this file ends up in the source tarball.
But the source tarball created on Linux won't have this file.
That doesn't sound like a good thing to me to have the content
of the source tarball depending on the machine you've run
'R CMD build'. In other words, you should try to generate this
src/xpsDict.h file at installation time but it shouldn't end up
in the source tarball.
My 2 cents...
Cheers,
H.
If you download the source code of my package from:
http://bioconductor.org/packages/2.7/bioc/html/xps.html
you will see that this file is not in the package.
However, I could indeed add the corrected files xpsDict.h and
xpsDict.cxx to the source code of my package. There is only one problem.
Currently the source code "xps_1.9.6.tar.gz" has a total size of 4MB.
Adding the corrected files will add another 4MB to the source code.
Best regards
Christian
On 9/14/10 9:59 PM, Simon Urbanek wrote:
On Sep 14, 2010, at 2:27 PM, cstrato wrote:
Dear Bill,
It would be great if this warning message could at least be
suppressed on Windows.
I think you're missing the point - you should be fixing that file
instead - it doesn't matter whether you're on Windows or not. If the
file is created automatically then it has no business being in the
package. Otherwise you should simply post-process it (e.g., as Dirk
suggested) after it has been generated but before you create the
package - that is the common practice with generated files that need
to be part of the distribution.
Cheers,
Simon
On 9/14/10 2:06 AM, William Dunlap wrote:
-----Original Message-----
From: r-devel-boun...@r-project.org
[mailto:r-devel-boun...@r-project.org] On Behalf Of cstrato
Sent: Monday, September 13, 2010 2:08 PM
To: r-devel@r-project.org
Subject: [Rd] Problem with WARNING...headers with CRLF line endings
Dear all,
When running R CMD check on Windows XP to test my package I get the
following warning message:
"* checking line endings in C/C++/Fortran sources/headers ... WARNING
Found the following sources/headers with CR or CRLF line endings:
src/xpsDict.h"
The problem is that this file is created by the compiler
AUTOMATICALLY
during the compilation process, and since the file is created
by VC++ on
WinXP, it will always have CRLF line endings.
Thus my question is:
- Is it really necessary to issues this warning message?
- If yes, could it be suppressed on Windows XP, since there it should
obviously be no problem.
Older versions of Sun C compilers would refuse to
compile code with Windows-style line endings. I don't
know if that is still the case. One reason to run check
is to see if there are any platform-dependencies in
code on CRAN so the warning should not be suppressed.
(The S+ package system tries to avoid the problem by changing
line endings on text files when it compiles the package.
It is not trivial to reliably figure out which files are
meant to be text files.)
Bill Dunlap
Spotfire, TIBCO Software
wdunlap tibco.com
One more issue:
While I have always received this warning on my WinXP
installation, for
some lucky reason the warning did until now not appear on the
Bioconductor Windows server, see BioC 2.6 with R-2.11.1:
http://bioconductor.org/checkResults/2.6/bioc-LATEST/xps/liver
pool-checksrc.html
However, for some reason on BioC 2.7 running R-2.12.0 this
warning does
appear, see:
http://bioconductor.org/checkResults/2.7/bioc-LATEST/xps/liver
pool-checksrc.html
For this reason I would appreciate if there would be a
possibility to
suppress this warning message.
Thank you in advance.
Best regards
Christian
_._._._._._._._._._._._._._._._._._
C.h.r.i.s.t.i.a.n S.t.r.a.t.o.w.a
V.i.e.n.n.a A.u.s.t.r.i.a
e.m.a.i.l: cstrato at aon.at
_._._._._._._._._._._._._._._._._._
______________________________________________
R-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel
______________________________________________
R-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel
______________________________________________
R-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel
--
Hervé Pagès
Program in Computational Biology
Division of Public Health Sciences
Fred Hutchinson Cancer Research Center
1100 Fairview Ave. N, M2-B876
P.O. Box 19024
Seattle, WA 98109-1024
E-mail: hpa...@fhcrc.org
Phone: (206) 667-5791
Fax: (206) 667-1319
______________________________________________
R-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel
