Wow! I never thought somebody would look at the makefile hell.
I have applied both patches. as long as they look ok, but I have some
comments here..
*) we depend on GNU make. so it's ok to use his extensions. I think is
the only "hard" dependency of radare
*) about -lmagic .. it would be better to have a single .mk with that
check and being enabled with USE_LIBMAGIC=YES so if USE_LIBMAGIC and
HAVE_LIBMAGIC is enabled this flag is appended to ldflags.
*) more on magic.. the idea will be to have our own implementation of
libmagic included inside radare. any volunteer? i think openbsd one is
the more decent one.. but still bloated.. so a reimplementation would be
good. It's in TODO for 0.9. Having -lmagic as dependency makes porting a
bit complex.
*) It's ok the use of absolute paths. i know there are some hacky things
here because of having to ../ ../.. and ../../.. to find stuff which is
ugly, but I didnt priorize
*) when you modify all those files bear in mind about not breaking the
static/dynamic/pic/nonpic build.
*) interl-lib dependencies are not properly handled, it would be great
if we could fix this without using automake. any idea here? keep in mind
those makefiles have to build:
- libraries
- static plugins
- shared plugins
- test programs
- programs
We can meet in IRC if you like to talk about it. I can help you in this
refactoring.
(ping me by mail if i'm not there)
--pancake
_______________________________________________
radare mailing list
[email protected]
http://lists.nopcode.org/listinfo.cgi/radare-nopcode.org
