A closer check revealed: Cmake simply ignores the ooc stuff alltogether
The Rmakefile builds object files from all the oocxxx.c files, but not for pmapooc.c. And finally in the sources, I found why: pmapdata.c #includes pmapooc.c (or alternatively pmapkdt.c), depending on -DPMAP_OOC. No provisions to actually set the latter, though. but that's an easy enough excercise... After a bit of digging about which files actually need that define, The SCons build now supports OOC for Pmap, with a configuration option aptly named - PMAP_OOC. It is enabled by default on unixoid systems and unavailable on Windows. The latter is because the code actively refuses to build on Windows. @Roland Are you still hibernating? Are there technically difficult reasons for this, or did you just not get around to fixing and testing it on Windows yet? At a quick glance through the code I didn't notice any particularly platform dependent stuff, but of course I may have missed something. -schorsch Am 2018-01-08 16:03, schrieb Guglielmetti, Robert:
Hi Georg! Long time. We are about done with a re-write of the Cmake build system as well, which allows us to do automated build/test/CI on our GitHub mirror of the Radiance CVS repo. Exciting times! There was some shuffling around of the pmap includes. It’s been building for us on Windows since late summer 2017, I’ll have to look and see what we are doing, unless Roland/Greg know offhand. - Rob On 1/8/18, 6:44 AM, "Georg Mischler" <schor...@schorsch.com> wrote: Hello everybody, As it is starting to turn into a new year's tradition, I've just updated the SCons build system once again. Good news 1: With Scons 3.1 (probably since 3.0), despite what the documentation says, it works very nicely with Python 3.x (3.6 in my case). After some adaptions from my side, this means that all the Python code in the Radiance distribution is now compatible with both Python 2.7 and 3.x. Good news 2:Microsoft has fixed their Universal CRT (didn't check in which version). This means that the line-end-eating bug in pipes is gone, and we canreliably build Radiance with the current Visual Studio tools again. I have now completely switched to VS 2017 myself. Open Issue: There's a buch of code relating to "out of core octree" building for Pmap. Most of this compiles fine, except for pmapooc.c, which is missing some header file includes. Unfortunately, that seems to be the central cornerstone binding all the others together... @Roland:Can you share some insight whether this is supposed to be working,or still a work in progress that I should ignore for the moment? Or alternatively, am I doing anything wrong for making it work? Cheers -schorsc --Georg Mischler -- simulations developer -- schorsch at schorsch com+schorsch.com+ -- lighting design tools -- https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.schorsch.com%2F&data=02%7C01%7Crobert.guglielmetti%40nrel.gov%7C1a1e1bdd09444585300608d5569dee6e%7Ca0f29d7e28cd4f5484427885aee7c080%7C0%7C0%7C636510158689605858&sdata=J%2FOY2UqprWww8V0qGdXHRiZ6SurpnVIwzQqHYzc5x1E%3D&reserved=0 _______________________________________________ Radiance-dev mailing list Radiance-dev@radiance-online.org https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.radiance-online.org%2Fmailman%2Flistinfo%2Fradiance-dev&data=02%7C01%7Crobert.guglielmetti%40nrel.gov%7C1a1e1bdd09444585300608d5569dee6e%7Ca0f29d7e28cd4f5484427885aee7c080%7C0%7C0%7C636510158689605858&sdata=UcMlmf4VOdZ%2FP3anQu%2F%2BJ7BY%2Bts7%2FYZYwdk0vmmbo78%3D&reserved=0 _______________________________________________ Radiance-dev mailing list Radiance-dev@radiance-online.org https://www.radiance-online.org/mailman/listinfo/radiance-dev
-- Georg Mischler -- simulations developer -- schorsch at schorsch com +schorsch.com+ -- lighting design tools -- http://www.schorsch.com/ _______________________________________________ Radiance-dev mailing list Radiance-dev@radiance-online.org https://www.radiance-online.org/mailman/listinfo/radiance-dev
