SinghSwayam left a comment (openstreetmap/openstreetmap-website#6669)
Thank you @mmd-osm, @HolgerJeromin, and @hlfan for the detailed feedback!
I agree that handling this in the View layer is much cleaner than using
JavaScript. I will rework the PR to:
* Move the Wiki URLs into config/layers.yml.
* Render the icon directly in app/views/layers_panes/show.html.erb using Rails
tags.
* Add the translation key to config/locales for accessibility.
I am working on these changes now and will push an update shortly.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6669#issuecomment-3706816845
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6669/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
