@pablobm commented on this pull request.
Had a quick look: the maps in the dashboard and the diary pages have stopped
working. On my machine, they work when I try your master branch.
> @@ -8,11 +8,11 @@
//= require leaflet/dist/leaflet-src
//= require leaflet.osm
//= require leaflet.shortbread
+//= require i18n
True, but that doesn't clarify anything 🙂 How about an explanation:
- Before this PR, `OSM.i18n` was used later, when specific secondary maps
(dashboard, diary) were loaded.
- With this PR, `leaftlet.maptiler` loads `maplibre.i18n`, which requires this
library. Therefore we need to make sure it's available beforehand.
> @@ -0,0 +1,36 @@
+const createRasterStyle = function (maxzoom, tileUrl) {
Sorry, I'm very ignorant about this code 😓 What yml are you referring to here?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6683#pullrequestreview-3650192966
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6683/review/[email protected]>_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
