@CommanderStorm commented on this pull request.


> @@ -0,0 +1,36 @@
+const createRasterStyle = function (maxzoom, tileUrl) {

We currently have these 3 definitions of which styles exist.
Would it not be nice to have 2 (and only one, once leaflet gets removed):

- 
[`layers.yml`](https://github.com/openstreetmap/openstreetmap-website/blob/master/config/layers.yml)
- [`leaflet.osm.js`](vendor/assets/leaflet/leaflet.osm.js)
- the place which I have added

Yes, they don't change all that often, but with 3 places, it is simple to miss 
one.
I think given that this is simpler once there are only 2 places, moving this to 
the future is likely simpler.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6683#discussion_r2681945030
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/6683/review/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to