Hi, On Tue, 2007-08-28 at 23:48 +0200, Edouard Gomez wrote: > Here i post my current patch queue: > - option to disable the optimizations
I'm fine with this - but we should not advertise it. It should only be used for debugging, not something users should fiddle with. > - (visual) enhancements to the curve widget Is the mouse cursor a problem with many themes? I'm somewhat reluctant fixing corner cases "just" because some cursor set has a big crosshair. > - luminance curve for int/float/sse/3dnow (at last) WUHU! Rock. Where does these luma coefficients come from? - and why are they better than RLUM and friends in color.h? > - bugfix in the preference panel Looks good. > Some questions i have so far: > - on my amd64 the 3dnow code as of SVN just crashes... is this known ? Oh no. How about release 0.6? > - 3dnow code uses pf2id which truncates floating values, my patch > adds 0.5 before truncating. This acheives proper rounding that is > used in float/sse. Were you aware of this ? Not at all ;) > Some caveats in the luminance curve: > - int/float/sse work perfectly, however the 3dnow version seems to > be buggy at the moment, the image colors are not modified the way > they should be, even w/o the curve applied... i've spent too much > time reading the code again and again, the 0.5 bias doesn't explain > the results i can see. Try #undef USE_3D_NOW_LUMINANCE_CURVE in > rs-color-trnsformation.c to see that the curve code isn't really > responsible for that yellowish color... I have an idea; We scrap the 3dnow-code? /abrander _______________________________________________ Rawstudio-dev mailing list [email protected] http://rawstudio.org/cgi-bin/mailman/listinfo/rawstudio-dev
