Anders Brander ([EMAIL PROTECTED]) wrote:
> Is the mouse cursor a problem with many themes? I'm somewhat reluctant
> fixing corner cases "just" because some cursor set has a big
> crosshair.

Not many themes  bring thin shaped cursors as these ones  tend to be not
visible on  users' screens  that are bigger  and bigger these  days.

> 
> >  - luminance curve for int/float/sse/3dnow (at last)
> 
> WUHU! Rock.

Hehe

> Where does these luma coefficients come from? - and why are they better
> than RLUM and friends in color.h?

These   are  the  luma   coefficients  found   in  the   XYZ  colorspace
definition.  I found  these  better  when looking  at  the screen.  With
RLUM... i  found the image  changing a bit  in chroma when  really going
strong/weak on the curve. I also tried the YUV (NTSC) standard...

I'm not opposed  to change these settings, it's just i  found them a bit
better fitted to real luma to my eyes.

> > Some questions i have so far:
> >  - on my amd64 the 3dnow code as of SVN just crashes... is this known ?
> 
> Oh no. How about release 0.6?

Crashes too.

> >  - 3dnow code uses pf2id which truncates floating values, my patch
> >    adds 0.5 before truncating. This acheives proper rounding that is
> >    used in float/sse. Were you aware of this ?
> 
> Not at all ;)

Now you are :-)

 
> > Some caveats in the luminance curve:
> >  - int/float/sse work perfectly, however the 3dnow version seems to
> >    be buggy at the moment, the image colors are not modified the way
> >    they should be, even w/o the curve applied... i've spent too much
> >    time reading the code again and again, the 0.5 bias doesn't explain
> >    the results i can see. Try #undef USE_3D_NOW_LUMINANCE_CURVE in
> >    rs-color-trnsformation.c to see that the curve code isn't really
> >    responsible for that yellowish color...
> 
> I have an idea; We scrap the 3dnow-code?

Hmm thoug it would be very easy,  i think that old systems deserve a bit
of respect :-) i'm sure i can find what's going on. For now i'd say that
if you're interested  in the patch just commit it,  i'll keep working on
the 3dnow code and if i really don't find where the problem lies... i'll
ask for removal.

Do you have an  idea how many people use rawstudio in  3dnow mode only ?
Starting with athlons, sse is available to amd users too.

-- 
Edouard Gomez

_______________________________________________
Rawstudio-dev mailing list
[email protected]
http://rawstudio.org/cgi-bin/mailman/listinfo/rawstudio-dev

Reply via email to