Hi!

The last one is another missing NULL check.

in gtk-helper.c:

gui_confbox_get_active() can return NULL, if nothing selected, that sets
"active" to NULL,

then this fails:

quick->output_type = g_type_name(GPOINTER_TO_INT(active));

The first one is a bit harder to figure out.



Regards, Klaus Post

http://www.klauspost.com


On Wed, Apr 6, 2011 at 21:07, Mathias Picker <[email protected]> wrote:

> Lovely. It now starts up fine, and all functions I tested seem to work.
>
> There are two crashes, though:
>
>  - Changing the output format in batch processing. The option menu is
> shown, after selecting any format/exporter rawstudio crashes.
> After starting rawstudio again the new settings are in effect, and
> everything works fine. Changing output format settings works flawlessly.
>
> Backtrace:
> Program received signal SIGSEGV, Segmentation fault.
> [Switching to Thread 8096041c0 (LWP 100170/initial thread)]
> 0x0000000802ead71d in g_type_name ()
> from /usr/local/lib/libgobject-2.0.so.0
> (gdb) bt
> #0  0x0000000802ead71d in g_type_name ()
> from /usr/local/lib/libgobject-2.0.so.0
> #1  0x0000000000427b7a in filetype_changed ()
> #2  0x000000000041e546 in gui_confbox_changed ()
> #3  0x0000000802e9009e in g_closure_invoke ()
> from /usr/local/lib/libgobject-2.0.so.0
> #4  0x0000000802ea6faf in g_signal_handlers_block_matched ()
> from /usr/local/lib/libgobject-2.0.so.0
> #5  0x0000000802ea8e82 in g_signal_emit_valist ()
> from /usr/local/lib/libgobject-2.0.so.0
> #6  0x0000000802ea9293 in g_signal_emit ()
> from /usr/local/lib/libgobject-2.0.so.0
> #7  0x00000008008aec92 in gtk_color_selection_dialog_new ()
> from /usr/local/lib/libgtk-x11-2.0.so.0
> #8  0x00000008008b0209 in gtk_combo_box_set_active_iter ()
> from /usr/local/lib/libgtk-x11-2.0.so.0
> #9  0x00000008008b0331 in gtk_combo_box_set_active_iter ()
> from /usr/local/lib/libgtk-x11-2.0.so.0
> #10 0x0000000802e9009e in g_closure_invoke ()
> from /usr/local/lib/libgobject-2.0.so.0
> #11 0x0000000802ea6faf in g_signal_handlers_block_matched ()
> from /usr/local/lib/libgobject-2.0.so.0
> #12 0x0000000802ea8e82 in g_signal_emit_valist ()
> from /usr/local/lib/libgobject-2.0.so.0
> #13 0x0000000802ea9293 in g_signal_emit ()
> from /usr/local/lib/libgobject-2.0.so.0
> #14 0x0000000800a482ee in gtk_widget_activate ()
> from /usr/local/lib/libgtk-x11-2.0.so.0
> #15 0x0000000800946323 in gtk_menu_shell_activate_item ()
> from /usr/local/lib/libgtk-x11-2.0.so.0
> #16 0x0000000800947cd5 in gtk_menu_shell_append ()
> from /usr/local/lib/libgtk-x11-2.0.so.0
> #17 0x000000080093846f in gtk_marshal_BOOLEAN__VOID ()
> from /usr/local/lib/libgtk-x11-2.0.so.0
> #18 0x0000000802e9009e in g_closure_invoke ()
> from /usr/local/lib/libgobject-2.0.so.0
> #19 0x0000000802ea716a in g_signal_handlers_block_matched ()
> from /usr/local/lib/libgobject-2.0.so.0
> #20 0x0000000802ea8b7e in g_signal_emit_valist ()
> from /usr/local/lib/libgobject-2.0.so.0
> #21 0x0000000802ea9293 in g_signal_emit ()
> from /usr/local/lib/libgobject-2.0.so.0
> #22 0x0000000800a45065 in gtk_widget_style_attach ()
> from /usr/local/lib/libgtk-x11-2.0.so.0
> #23 0x00000008009310f9 in gtk_propagate_event ()
> from /usr/local/lib/libgtk-x11-2.0.so.0
> #24 0x000000080093227b in gtk_main_do_event ()
> from /usr/local/lib/libgtk-x11-2.0.so.0
> #25 0x0000000800d631cc in gdk_add_client_message_filter ()
> from /usr/local/lib/libgdk-x11-2.0.so.0
> #26 0x0000000803e7d062 in g_main_context_dispatch ()
> from /usr/local/lib/libglib-2.0.so.0
> #27 0x0000000803e80930 in g_main_context_prepare ()
> from /usr/local/lib/libglib-2.0.so.0
> #28 0x0000000803e80d46 in g_main_loop_run ()
> from /usr/local/lib/libglib-2.0.so.0
> #29 0x00000008009325d2 in gtk_main ()
> from /usr/local/lib/libgtk-x11-2.0.so.0
> #30 0x0000000000421984 in gui_init ()
> #31 0x000000000041731e in main ()
>
>  - same with Edit->Options, rawstudio crashes before the option dialog
> is shown.
> backtrace:
> Program received signal SIGSEGV, Segmentation fault.
> [Switching to Thread 8096041c0 (LWP 100763/initial thread)]
> 0x0000000802ead71d in g_type_name ()
> from /usr/local/lib/libgobject-2.0.so.0
> (gdb) bt
> #0  0x0000000802ead71d in g_type_name ()
> from /usr/local/lib/libgobject-2.0.so.0
> #1  0x000000000041fdc4 in gui_make_preference_window ()
> #2  0x0000000802e9009e in g_closure_invoke ()
> from /usr/local/lib/libgobject-2.0.so.0
> #3  0x0000000802ea6faf in g_signal_handlers_block_matched ()
> from /usr/local/lib/libgobject-2.0.so.0
> #4  0x0000000802ea8e82 in g_signal_emit_valist ()
> from /usr/local/lib/libgobject-2.0.so.0
> #5  0x0000000802ea9293 in g_signal_emit ()
> from /usr/local/lib/libgobject-2.0.so.0
> #6  0x0000000800876473 in gtk_widget_get_action ()
> from /usr/local/lib/libgtk-x11-2.0.so.0
> #7  0x0000000802e9009e in g_closure_invoke ()
> from /usr/local/lib/libgobject-2.0.so.0
> #8  0x0000000802ea6cb5 in g_signal_handlers_block_matched ()
> from /usr/local/lib/libgobject-2.0.so.0
> #9  0x0000000802ea8e82 in g_signal_emit_valist ()
> from /usr/local/lib/libgobject-2.0.so.0
> #10 0x0000000802ea9293 in g_signal_emit ()
> from /usr/local/lib/libgobject-2.0.so.0
> #11 0x0000000800a482ee in gtk_widget_activate ()
> from /usr/local/lib/libgtk-x11-2.0.so.0
> #12 0x0000000800946323 in gtk_menu_shell_activate_item ()
> from /usr/local/lib/libgtk-x11-2.0.so.0
> #13 0x0000000800947cd5 in gtk_menu_shell_append ()
> from /usr/local/lib/libgtk-x11-2.0.so.0
> #14 0x000000080093846f in gtk_marshal_BOOLEAN__VOID ()
> from /usr/local/lib/libgtk-x11-2.0.so.0
> #15 0x0000000802e9009e in g_closure_invoke ()
> from /usr/local/lib/libgobject-2.0.so.0
> #16 0x0000000802ea716a in g_signal_handlers_block_matched ()
> from /usr/local/lib/libgobject-2.0.so.0
> #17 0x0000000802ea8b7e in g_signal_emit_valist ()
> from /usr/local/lib/libgobject-2.0.so.0
> #18 0x0000000802ea9293 in g_signal_emit ()
> from /usr/local/lib/libgobject-2.0.so.0
> #19 0x0000000800a45065 in gtk_widget_style_attach ()
> from /usr/local/lib/libgtk-x11-2.0.so.0
> #20 0x00000008009310f9 in gtk_propagate_event ()
> from /usr/local/lib/libgtk-x11-2.0.so.0
> #21 0x000000080093227b in gtk_main_do_event ()
> from /usr/local/lib/libgtk-x11-2.0.so.0
> #22 0x0000000800d631cc in gdk_add_client_message_filter ()
> from /usr/local/lib/libgdk-x11-2.0.so.0
> #23 0x0000000803e7d062 in g_main_context_dispatch ()
> from /usr/local/lib/libglib-2.0.so.0
> #24 0x0000000803e80930 in g_main_context_prepare ()
> from /usr/local/lib/libglib-2.0.so.0
> #25 0x0000000803e80d46 in g_main_loop_run ()
> from /usr/local/lib/libglib-2.0.so.0
> #26 0x00000008009325d2 in gtk_main ()
> from /usr/local/lib/libgtk-x11-2.0.so.0
> #27 0x0000000000421984 in gui_init ()
> #28 0x000000000041731e in main ()
>
> Hope this gives you an idea :)
>
> Cheers, Mathias
>
_______________________________________________
Rawstudio-users mailing list
[email protected]
http://rawstudio.org/cgi-bin/mailman/listinfo/rawstudio-users

Reply via email to