On Fri, Aug 11, 2006 at 02:50:28PM +0200, Markus Raab wrote: > Am Dienstag, 1. August 2006 01:27 schrieb Patrice Dumas: > > Hello, > > I did that;)
> > I think that it is bad, setting CFLAGS > > (except for -I) should be left to the user compiling elektra (or the > > packager) and ./configure. > > The problem is many parts throw out hundret of warnigns when compiling with > -Wall. I even think some parts fail with -ansi and -pedantic (correct me if I > am not right). For me -ansi add more warnings, since it complains for functions that are not in C99 but are in previous standards. -pedantic don't change anything. Most warnings triggered by -Wall are fixed now in CVS. > That was the reason why I added it there where it compiles with that options. That's very strange. Is it still the case? The cvs version now adds -Wall if compiler is gcc and CFLAGS is empty. But I removed -pedantic, -ansi (and -Wall) everywhere in the Makefile.am. > elektra does not work with anything then gcc for now;) Is it sure? I tried a quick compilation on solaris with sun cc, there are tons of warnings but it stops at the exact same place than gcc, since getmntent is not portably defined. But as I said in another mail, porting to another platform leads frequently to issues, while changing the compiler isn't an issue most of the time. > > * to left the choice to the use compiling elektra. For example a > > user may ant to set -Werror but not -Wall > > can't do that both? Of course it is possible to set both, but it makes sense to set Werror but not Wall such that build stops on any warning except thoses generated by Wall. > If you can convice me, I will remove it (and not add it anywhere again). But > gcc is the only working and does -Werror and-Wall break it? Indeed, since there are still warnings remaining with -Wall. > Can you show me another solution to add -ansi -pedantic for only parts of > elektra? There is no other solution. Currently I have removed those options, but I can readd those if you need to. However I fail to see why they should be needed. -- Pat ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Registry-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/registry-list
