On Tue, Jun 28, 2005 at 12:37:11PM +0400, Vladimir Saveliev wrote: > have neither prof.[ch], nor spinprof.[ch] and we removed already some > debugging code from spin_macros.h.
Yes, i was looking at some older tree with reiser4. Sorry, just ignore what is already done. But still spin_macros.h should be completely removed imho. Such custom lock wrappers are strongly discouraged because it makes it hard for others to read your code. > > statcnt.h: This is completely useless because you don't align > > the individual fields for cache lines - so you will still > > have false sharing everywhere. Also using NR_CPUS is nasty > > because it can be very big - num_possible_cpus() is better. > > It should use the new dynamic per cpu allocator. > > > statcnt.h is already removed. Great. -Andi
