On Fri, Nov 25, 2011 at 9:09 AM, Thomas Zander <zan...@kde.org> wrote: > On Wednesday 23 November 2011 18.25.23 Pau Garcia i Quiles wrote: >> On Wed, Nov 23, 2011 at 4:21 PM, Thomas Zander <zan...@kde.org> wrote: >> > I too think that a much less invasive patch has to be the first step to >> > getting something accepted. >> >> As I said in k-c-d, the patch is deliberately invasive. It's no accident. > > The invasive nature makes the patch a high risk to integrate into a stable > branch. It would be more appropriate for the frameworks, not so much for the > frozen kdelibs. > > I think everyone understands your goal, and why you made it deliberately > invasive. But the first priority has to go to the stability of kde apps. And > when I last hacked the menu-merging code, I was surprised of its complexity > and how easy it is to break one of the millions of apps using this code. > So, your intention to be extra invasive means the patch is too high risk for > kdelibs. > > As 2 other people also have suggested, I think you should try to get your > patch into frameworks, not kdelibs. And try a much simpler approach (just > some text added and maybe a new tab) for kdelibs. > > Hope that clarifies my previous mail :)
>From my first e-mail: --8<--- Why is it important that we get this in now? - Because 4.8 is probably the last release before 5.0 - Given our history with 4.0, I wouldn't be surprised if users and distributions avoid 5.0 as the default, or even altogether - This means either the Join the Game propaganda goes in for 4.8, or it will not arrive to our users before 18-24 months (~12 months till 5.0 + 6 months for 5.1 + distributions delay + ...). No matter how optimistic we are about releasing 5.0 soon, history shows there are always delays. - We cannot wait 18 months --8<--- Also, making the patch non-invasive means the visibility of Join the Game plummets. I'm quite disappointed people have spent more time answering e-mails than testing the code. -- Pau Garcia i Quiles http://www.elpauer.org (Due to my workload, I may need 10 days to answer) _______________________________________________ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team