THere is a finalize in ApacheHttpClient4Engine. We actually have a unit test that tests GC for responses and clients.
But, you should never rely on finalize. Its really bad practice. The examples are a poor job on my end if they don't do close. On 5/28/2014 5:16 PM, Guy Rouillier wrote: > Thanks for the reply, Bill. I cloned the RESTEasy repo so I could look > at the latest source. I see that ResteasyClient.java has a close() > method, but no finalize(). So, I suppose the most conservative course > of action would be to specifically invoke ResteasyClient.close() in a > finally block for any code that creates an instance. > > On 5/28/2014 8:06 AM, Bill Burke wrote: >> Oh, one more thing. ResteasyClient does implement finalize and will >> close during garbage collection. >> >> On 5/28/2014 12:49 AM, Guy Rouillier wrote: >>> The RESTEasy documentation specifically says (section 48.3): >>> >>> "Finally, if your javax.ws.rs.client.Client class has created the engine >>> automatically for you, you should call Client.close() and this will >>> clean up any socket connections." >>> >>> Yet the overwhelming majority of examples I can find, including those >>> shipped with RESTEasy, do not explicitly invoke Client.close(). Is this >>> because resource cleanup will eventually be done automatically during >>> garbage collection? >>> >>> We are using the ResteasyClient proxy approach, but that class extends >>> Client, so I'm assuming the same discussion holds for the proxy. >>> >>> Thanks. >>> >> > > -- Bill Burke JBoss, a division of Red Hat http://bill.burkecentral.com ------------------------------------------------------------------------------ Time is money. Stop wasting it! Get your web API in 5 minutes. www.restlet.com/download http://p.sf.net/sfu/restlet _______________________________________________ Resteasy-users mailing list Resteasy-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/resteasy-users
