Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 891 by schlaber: LDAP enhancements
http://code.google.com/p/reviewboard/issues/detail?id=891

1)
Look at the attached image. It's not clear, that one of this two fields
must be filled out. If both fields are empty, there is an error during  
logon.

-------------------------------
if settings.LDAP_EMAIL_DOMAIN:
     email = u'%...@%s' % (username, settings.LDAP_EMAIL_DOMAIN)
elif settings.LDAP_EMAIL_ATTRIBUTE:
     email = passwd[0][1][settings.LDAP_EMAIL_ATTRIBUTE][0]

user = User(username=username,
             password='',
             first_name=first_name,
             last_name=last_name,
             email=email)
-------------------------------

2)
Is there a good reason why the scope is fix ldap.SCOPE_ONELEVEL? It would
be great if there could be an additional setting. I have to search in the
scope ldap.SCOPE_SUBTREE

-------------------------------
class LDAPBackend:
     def authenticate(self, username, password):
         ....
         search = ldapo.search_s(settings.LDAP_BASE_DN, ldap.SCOPE_ONELEVEL,
                                 uid)
-------------------------------

Attachments:
        rb-ldap.png  21.6 KB

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to