Comment #3 on issue 891 by ru.w31rd0: LDAP enhancements
http://code.google.com/p/reviewboard/issues/detail?id=891

It also assumes that attributes `givenName` and `sn` are always present,  
which is not
necessary true.
-----
first_name = passwd[0][1]['givenName'][0]
last_name = passwd[0][1]['sn'][0]
-----

Maybe it's a good idea to have a fallback like this?
-----
first_name = username
last_name = ''
-----


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to