Comments are tied to a revision of a diff. They cant carry over to another revision, since the code may change and lines won't sync up or make any sense anymore.
You should be using the Review Request page to see what comments were made to certain lines. You can also use interdiffs to see what changed between two revisions of a diff. Christian -- Christian Hammond - [EMAIL PROTECTED] VMware, Inc. On Wed, Nov 5, 2008 at 1:47 AM, Dev <[EMAIL PROTECTED]> wrote: > > Hi, > Can anyone pl tell me why i am not able to see comments for second > revision of diff file?It's very difficult for me to verify what > exactly is fixed in 2nd revision of diff file. > > Awaiting for reply. > > Regards, > dev > > > On Oct 30, 11:20 am, Dev <[EMAIL PROTECTED]> wrote: > > Atlast got it work ..!Thanks. > > > > On Oct 28, 2:04 pm, Dev <[EMAIL PROTECTED]> wrote: > > > > > Ok Christian ..:) > > > I have added repository like svn+ssh://10.x.x.x/svn/careers .After > > > adding this i shall be able to create a review.But when i click "View > > > Diff" button in gui,it get hung.i looked into the log.It is asking for > > > the "[EMAIL PROTECTED]'s Password: " .I am just confused. > > > > > Can you pl help me in this regard.?I am waiting for yr comment > > > christian ..:) > > > > > Regards, > > > dev > > > > > On Oct 28, 1:32 pm, "Christian Hammond" <[EMAIL PROTECTED]> wrote: > > > > > > No prob, glad it works! > > > > > > (By the way, "Christy" is more of a girl's name. "Christian" is > probably > > > > best ;)) > > > > > > Christian > > > > > > -- > > > > Christian Hammond - [EMAIL PROTECTED] > > > > VMware, Inc. > > > > > > On Tue, Oct 28, 2008 at 12:54 AM, Dev <[EMAIL PROTECTED]> wrote: > > > > > > > Hi christy, > > > > > > > Thanks for yr timely help.It works now ..! > > > > > Thanks again..! > > > > > > > On Oct 24, 12:00 pm, "Christian Hammond" <[EMAIL PROTECTED]> > wrote: > > > > > > You probably want the server to be svn+ssh://10.x.x.x/data/svn > and the > > > > > > username to be username. > > > > > > > > I'm assuming "careers" is a directory inside your SVN repository. > If > > > > > that's > > > > > > actually the SVN server's base path, then that should be part of > the path > > > > > in > > > > > > the server. > > > > > > > > It would help to see what errors you're seeing. > > > > > > > > Christian > > > > > > > > -- > > > > > > Christian Hammond - [EMAIL PROTECTED] > > > > > > VMware, Inc. > > > > > > > > On Tue, Oct 21, 2008 at 7:36 AM, Dev <[EMAIL PROTECTED]> > wrote: > > > > > > > > > The format of the repository path is > "svn+ssh://[EMAIL PROTECTED] > > > > > /data/ > > > > > > > svn/careers" > > > > > > > Is this correct? Or i need to change the format? > > > > > > > > > Pl help. > > > > > > > > > On Oct 21, 6:27 pm, Dev <[EMAIL PROTECTED]> wrote: > > > > > > > > Thanks..I am done in this part. > > > > > > > > > > Now i stuck in adding multiple repositories. > > > > > > > > Actually i use subversion as scm.I have added repository url > path > > > > > > > > correctly and it works fine when i try to check-in for review > in > > > > > > > > command line.Works perfect. > > > > > > > > Then i added one more subversion repository in GUI and saved > and try > > > > > > > > to upload a file through command line,it says an error "Error > > > > > creating > > > > > > > > review request: The repository path specified is not in the > list of > > > > > > > > known repositories (code 206)" > > > > > > > > > > I am stuck again here. > > > > > > > > Pl help me. > > > > > > > > Awaiting for yr reply. > > > > > > > > > > Regards, > > > > > > > > dev > > > > > > > > > > On Oct 21, 12:43 pm, "Christian Hammond" < > [EMAIL PROTECTED]> > > > > > wrote: > > > > > > > > > > > On Mon, Oct 20, 2008 at 11:12 PM, Dev <[EMAIL PROTECTED]> > wrote: > > > > > > > > > > > > Thanks Christy ..! I have added reviewers . > > > > > > > > > > Can you pl clarify my below doubts ..? > > > > > > > > > > > > 1.For uploading a file "admin.py" to review,i am just > giving the > > > > > base > > > > > > > > > > path (say accounts/)and created a DIFF file of admin.py > and > > > > > giving > > > > > > > the > > > > > > > > > > DIFF file path in Browse.Now i can able to see the DIFF > file.Am i > > > > > > > > > > following right procedure?Pl clarify. > > > > > > > > > > > You never upload files directory. You upload a diff, > generated by > > > > > "svn > > > > > > > diff" > > > > > > > > > or by using post-review (which is easiest -- check the wiki > for > > > > > > > > > instructions). > > > > > > > > > > > When uploading a diff from "svn diff", the base path is the > SVN > > > > > path to > > > > > > > the > > > > > > > > > directory you were in when you ran "svn diff". So, if your > checkout > > > > > > > > > directory is /trunk/myproject, and that's where you > generated the > > > > > diff, > > > > > > > > > that's the "base path". > > > > > > > > > > > post-review will calculate the base path for you. > > > > > > > > > > > 2.After finishing review,if author clicks "setsubmitted" > button,Is > > > > > it > > > > > > > > > > > > possible to check-in directly to SVN.? > > > > > > > > > > > No, there's permission issues that prevent this from > working > > > > > easily. > > > > > > > You'll > > > > > > > > > have to commit by yourself. > > > > > > > > > > > 3.Is it possible to upload multiple files in single > instance for > > > > > > > > > > > > review?If so, How? > > > > > > > > > > > Yes, by generating a diff instead of uploading files > themselves. > > > > > > > > > > > Christian > > > > > > > > > > > -- > > > > > > > > > Christian Hammond - [EMAIL PROTECTED] > > > > > > > > > VMware, Inc. > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~----------~----~----~----~------~----~------~--~---
