Yes, it should work with 1.0.5.x. You should certainly be able to do the multiple patch thing today, though as Dan said, not elegantly. I think down the road we're going to want to look into patchset functionality. Internally, we already have a concept of a revisioned set of diffs (a "DiffSetHistory"). Today, a review request points to a single one of these, but in the future, we should be able to modify this so that it can point to more than one. The diff viewer would then allow switching between these.
This would be a great Summer of Code project, actually. It's probably not all that difficult, though we'd need to figure out some backwards-compatibility issues, and make the API work well with it. I haven't given this much thought yet, but what I'm envisioning is that the diff viewer, when linking to multiple patchsets, would show a list of each one somewhere above the revision selector, and the user could specify which one to look at. Each patchset would be capable of having multiple revisions of diffs just like today (though I'm not entirely sure how useful this is -- maybe outside of the standard Git patchset model). Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Thu, Feb 4, 2010 at 11:45 AM, Dan Savilonis <d...@n-cube.org> wrote: > See the Distributed Version Control Systems section of: > http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/ > > It's definitely available, and I believe it should work with git in > 1.0.5.1, but TBH I've never run the stable version of RB. > > In a 3 patch series, for example, you'd submit the first patch > directly, then the second patch with a parent diff of the first patch, > then the third patch with a parent diff of the sum of the first two > patches. > > Dan > > On Feb 4, 10:33 am, Stephen Gallagher <karrde...@gmail.com> wrote: > > On Feb 4, 10:20 am, Dan Savilonis <d...@n-cube.org> wrote: > > > > > post-review can actually generate any arbitrary diff, not just a diff > > > against HEAD. Make sure you're using the latest nightly build of > > > rbtools for this functionality. It also supports a 'parent diff' mode > > > where you can specify a parent of your diff set such that if you are > > > submitting a series of patches not available in the server's repo, RB > > > will still be able to understand how to generate the side-by-side > > > diff. > > > > Can you point me at some documentation for the parent diff mode? I'd > > like to understand more about this. Is it available in the stable > > 1.0.5.1, or does it require the 1.1 alpha? > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~----------~----~----~----~------~----~------~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com<reviewboard%2bunsubscr...@googlegroups.com> > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~----------~----~----~----~------~----~------~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
