Yeah, it does sound like it’s not executing.

Try removing the .pyc file, just to check.

Christian
-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

On June 26, 2014 at 10:12:41 AM, fireworm (firewor...@gmail.com) wrote:

Ok, adding garbage text to the python is not causing the server to go down, I'm 
thinking my updates aren't taking effect.

More sanity checking: I don't have any of the developer code installed and am 
modifying the install itself, right?  I don't need to update an executable 
somewhere forcibly?

The folder which I'm updating the python is in:

/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard

I see the pyc get updated, but again, it just runs happily, which seems very 
suspicious to me.

I even put logging in webapi/resources/review_request.py, in _find_user(), 
which didn't update.

Does any of this make sense?

On Thursday, June 26, 2014 9:46:30 AM UTC-7, fireworm wrote:
...I get the feeling my changes to the python are somehow not being actually 
run.

Is there a place I can put a logging.debug() call that absolutely gets hit 100% 
of the time to make sure i can see it?

On Thursday, June 26, 2014 9:19:22 AM UTC-7, fireworm wrote:
Local Site: Not that I'm aware. (I don't know what it is...)

Yep, Authentication Settings are Active Directory.  (New Users can login via AD 
just fine.)

On Thursday, June 26, 2014 12:49:57 AM UTC-7, Christian Hammond wrote:
Hmm, it should be called under those conditions.

Just to check, are you using the Local Sites feature? (If you don’t know what 
that is, then no.)

Can you also just verify in Authentication Settings that it’s Active Directory 
and not LDAP?

Christian

-- 
Christian Hammond - chri...@beanbaginc.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

On June 25, 2014 at 9:21:24 AM, fireworm (firew...@gmail.com) wrote:

Christian:

Open an existing review open in the RB website.
Click the pencil under 'People' (which brings up a text box that is empty (no 
one is currently on the review)).
Type in a name in our domain that doesn't have an account yet.  (Other accounts 
show up in the 'intellisense'.)
Hit Enter.
Message in red says "User '<the name I typed in>' does not exist."

Bruce:

Yes, looking at the server log I even see other logs at DEBUG and INFO level.

18:08:32         WARNING                

 - 
/usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/http/response.py:327:
 DeprecationWarning: Using mimetype keyword argument is deprecated, use 
content_type instead
  super(HttpResponse, self).__init__(*args, **kwargs)
18:52:28         DEBUG          

 - DiffParser.parse: Beginning parse of diff, size = 16150

On Wednesday, June 25, 2014 7:41:39 AM UTC-7, Bruce Cran wrote:
Have you bumped the logging level to DEBUG in the admin settings?

--
Bruce


On Tue, Jun 24, 2014 at 7:02 PM, fireworm <firew...@gmail.com> wrote:
I modified the one in 
/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/accounts/backend.py

Then I restarted Apache, and reloaded the page, and tried to add a user who 
doesn't have an RB account.

(I see an updated pyc in that folder as well)

But I don't see anything in reviewboard.log or the apache error.log.
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to