OK, thanks David. Regards
Kevan On Tuesday, 12 August 2014 09:22:55 UTC+10, David Trowbridge wrote: > > TRACKING_BRANCH should be set to something which is present in the > upstream copy of the repository that Review Board is talking to. In > general, it should be whichever branch you are looking to eventually merge > to. > > For example, in Review Board itself we have a .reviewboardrc which defines > TRACKING_BRANCH for each of our long-lived branches -- if one branches from > the release-2.0.x branch, TRACKING_BRANCH is set to origin/release-2.0.x, > or if branching from master, TRACKING_BRANCH is set to origin/master. > > -David > > > On Thu, Aug 7, 2014 at 5:44 PM, Kevan Stannard <kevans...@gmail.com > <javascript:>> wrote: > >> Many thanks Christian. >> >> If we're working in our own branch then what value should we use for >> TRACKING_BRANCH >> in .reviewboardrc? >> >> At the moment we've committed .reviewboardrc, but perhaps we should add >> it to git's ignore list and just set the TRACKING_BRANCH to our own >> working area branch? >> >> Thanks >> >> >> On Thursday, 7 August 2014 06:53:56 UTC+10, Christian Hammond wrote: >> >>> Hi Kevan, >>> >>> That’s the workflow, though we strongly encourage you to post to a >>> branch based off master, and then only merge to master once it’s reviewed. >>> >>> rbt post will post from the upstream tracking branch (defaulting to >>> origin/master, customizable by TRACKING_BRANCH in .reviewboardrc or >>> —tracking-branch) to HEAD. In your case, it’s only posting the latest >>> commit because you’re committing to master, and have one change from >>> origin/master to there. >>> >>> If you set up Default Reviewers on Review Board, you won’t need to >>> choose any reviewers. >>> >>> Christian >>> >>> -- >>> Christian Hammond - chri...@beanbaginc.com >>> >>> Review Board - http://www.reviewboard.org >>> Beanbag, Inc. - http://www.beanbaginc.com >>> >>> On August 5, 2014 at 10:42:45 PM, Kevan Stannard (kevans...@gmail.com) >>> wrote: >>> >>> I've been reading the workflow page here: >>> https://www.reviewboard.org/docs/manual/2.0/users/getting- >>> started/workflow/ >>> >>> We're planning to follow the pre-commit workflow. >>> >>> Would be grateful if someone could clarify some of the steps for us. >>> Here's my current understanding of the first few steps: >>> >>> *1) Make a change to your local source tree.* >>> >>> Here we: >>> a) Edit a file >>> b) Commit the change >>> >>> >>> *2) Create a review request for your new change.* >>> >>> Here we: >>> a) Run rbt post (which seems to post the latest commit?) >>> >>> *3) Publish the review request and wait for your reviewers to see it.* >>> >>> Here we: >>> a) Log into Review Board >>> b) Choose reviewers >>> c) Publish the review request >>> >>> >>> At the moment we are all committing to master, then push to our origin >>> regularly. >>> >>> Thanks >>> >>> >>> -- >>> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ >>> --- >>> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ >>> --- >>> Happy user? Let us know at http://www.reviewboard.org/users/ >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "reviewboard" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to reviewboard...@googlegroups.com. >>> >>> For more options, visit https://groups.google.com/d/optout. >>> >>> -- >> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ >> --- >> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ >> --- >> Happy user? Let us know at http://www.reviewboard.org/users/ >> --- >> You received this message because you are subscribed to the Google Groups >> "reviewboard" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to reviewboard...@googlegroups.com <javascript:>. >> For more options, visit https://groups.google.com/d/optout. >> > > -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
