First of all, thanks for the replies; I appreciate the help. @Stephen Gallagher I think this is were I am failing to communicate. I'm not trying to have my Git repository or web viewer to represent the file hashes as I haven't pushed anything to a remote Git repository. I'm hoping to avoid this by providing raw patches with full Git indexes to fill in the gap.
I'm going off the concept I see here <https://www.reviewboard.org/docs/manual/2.0/webapi/2.0/resources/diff-list/> . A parent diff can be uploaded along with the main diff. A parent diff is a > diff based on an existing commit in the repository, which will be applied > before the main diff. The parent diff will not be included in the diff > viewer. It’s useful when developing a change based on a branch that is not > yet committed. In this case, a parent diff of the parent branch would be > provided along with the diff of the new commit, and only the new commit > will be shown. > I'm assuming that ReviewBoard just doesn't support multiple parent diffs. My current work around is to squash the series of parent commits for a given patch and add rebase my commits off their respective squashed parents. This will provide me with both my diff to review and a parent diff that I can submit to ReviewBoard. For example: {Local} Commit 4 | Commit 3 | Commit 2 Commit 3b Commit 4b | | | Commit 1 Squash Commit 1-2 Squash Commit 1-3 | | | |-------------|-------------------- | Commit F | Commit E - - Make review 1 with `Commit 1` patch. - Make review 2 with `Commit 2` patch with parent `Commit 1` patch. - Make review 3 with `Commit 3b` patch with parent `Squash Commit 1-2` patch. - Make review 4 with `Commit 4b` patch with parent `Squash Commit 1-3` patch. Again, I know this isn't ideal but it works for now. @David Trowbridge I can't use the GitLab optional since it requires (to my knowledge) it's either for online GitLab hosting (which it not what I'm using; using a local GitLab CE installation) or requires an account setup on the GitLab server (which again, will not for us since we use LDAP and favor deployment keys). Unless there's another option I'm missing? On Thursday, April 23, 2015 at 4:03:59 PM UTC-4, David Trowbridge wrote: > > Yeah, the raw file URL needs to have the revision in there somewhere. > Since you're using GitLab, you should just choose "GitLab" instead of "None > - Custom Repository" > > -David > > On Thu, Apr 23, 2015 at 10:52 AM Stephen Gallagher < > ste...@gallagherhome.com <javascript:>> wrote: > >> On Thu, Apr 23, 2015 at 11:49 AM James Knight <james.d...@live.com >> <javascript:>> wrote: >> >>> Repository options are configured as follows: >>> >>> - Hosting Service: None - Custom Repository >>> - Repository Type: Git >>> - Path: git@myserver:mygroup/myproject.git >>> - Raw file URL mask: http://myserver/mygroup/myproject/raw/develop/ >>> <filename> >>> >>> >> This isn't going to work if you don't have a way to represent the >> individual file hashes. That's why it can't find them to compare. What tool >> are you using to view the files via the web? Generally, cgit and gitweb >> work best. >> >> -- >> Supercharge your Review Board with Power Pack: >> https://www.reviewboard.org/powerpack/ >> Want us to host Review Board for you? Check out RBCommons: >> https://rbcommons.com/ >> Happy user? Let us know! https://www.reviewboard.org/users/ >> --- >> You received this message because you are subscribed to the Google Groups >> "reviewboard" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to reviewboard...@googlegroups.com <javascript:>. >> For more options, visit https://groups.google.com/d/optout. >> > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
