Hi Hugh, Code can change a lot between uploads. A comment on a line in diff r1 may not in any way match up to the same line in diff r2 (and may not even exist -- files may shrink from one iteration to the next), so we can't just copy comments over. The code may have moved elsewhere in the file, or into a different file, or been rewritten so much that the original comment makes no sense. No matter what, you'll be comparing the old code to the new, based on what has happened in the second revision.
What I do is view the interdiff between the two revisions in a second tab. That lets me see all the changes that were made, helping me to determine how that code has changed, and to see whether my comment was in fact properly addressed. You can get to this by dragging the sliders in the diff viewer to cover both revisions, or click the "Show changes" link in the review request update. Christian On Tue, Aug 28, 2018 at 3:46 PM Hugh White <hugh.whi...@gmail.com> wrote: > Hi, > > I am struggling to understand the work-flow for verifying an author has > fixed an issue. > > For example, let's say John creates a review. I look at the diff (Diff > #1), and make a comment. He uploads another diff (Diff #2) to resolve this > comment. I would expect that I could see my original comment and Diff #2 so > that I can verify my concern was addressed. However, on the Review Tab, > each issue only shows the diff when it was created (Diff #1), and under the > Diff Tab, the comments made on Diff #1 are only visible when Diff #1 is > selected. > > How do you see the issue documenting the requested change and the > resolution diff? I've used other tools where issues are tied to files, > regardless of diff, so you can work an issue across multiple commits. > > Thanks! > > Hugh > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "Review Board Community" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Christian Hammond President/CEO of Beanbag <https://www.beanbaginc.com/> Makers of Review Board <https://www.reviewboard.org/> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "Review Board Community" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
