Hi Gabriel,

I’m sorry, it did fall through the cracks.

I’m still not sure I’m getting it. So right now, in Review Board, say you
have this scenario:

1) Post a change for review (diff 1, based on #20)
2) Sync, make some further changes and post again (diff 2, now based on #21)

The revision slider would allow you to view:

1) Diff 1’s changes (against #20)
2) Diff 2’s changes (against #21)
3) Diff 2’s changes against Diff 1 (this is an interdiff)

Interdiffs do filter out upstream changes (new content synced in-between
the two diff uploads), but what the documentation is saying is that you may
still see some changes show up if they are woven into lines that diff 2 is
modifying, or in some cases directly around those lines. This all depends
on how the diff algorithm is seeing those changes, and whether our
heuristics determine that those changes can be filtered out or are best
shown.

I’m having trouble understanding what option #4 for the slider would be, in
your example. Diff 2 against #20?

Christian


On Fri, Jul 19, 2019 at 06:57 Gabriel Morin <gabrielmo...@gmail.com> wrote:

> Hi Christian,
>
> I guess this question feel through the cracks, would it be possible to
> have your take on whether this feature will be added to RB in the future?
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "Review Board Community" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/reviewboard/2640d340-e49f-4295-8257-0b388c2957b0%40googlegroups.com
> .
>
-- 
-- 
Christian Hammond
President/CEO of Beanbag
Makers of Review Board

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/CAE7Vndmim1E0pywHpUeSZox4v%3Dxteajynn0TDJyhK3AEcye3tA%40mail.gmail.com.

Reply via email to