----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44725/ -----------------------------------------------------------
(Updated March 17, 2016, 6:52 p.m.) Review request for Ambari, Di Li and Robert Nettleton. Changes ------- Currently Secret References are getting filtered based on Property Name, but as properties are ending with difference strings (password, secret, pass), the filtering expression needs to be modified every time. As these password properties have values that follow the same format "SECRET:property_name:version:property_name" we can filter Secret References based on property value, rather than property name, as this would make it generic. Bugs: AMBARI-15338 https://issues.apache.org/jira/browse/AMBARI-15338 Repository: ambari Description ------- After exporting blueprint from ranger enabled cluster ranger.service.https.attrib.keystore.pass is exported. Which needs to be removed before using the same blueprint to create another cluster Error Show when used same blueprint: { "status" : 400, "message" : "Blueprint configuration validation failed: Secret references are not allowed in blueprints, replace following properties with real passwords:\n Config:ranger-admin-site Property:ranger.service.https.attrib.keystore.pass\n" } Diffs (updated) ----- ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java f5e7578 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java 68d5755 Diff: https://reviews.apache.org/r/44725/diff/ Testing ------- Modified test cases to test for if the properties that end with "pass" are getting filtered. Other properties which have 'pass' else where in the name will not get filtered. Thanks, Amruta Borkar