> On March 23, 2016, 8:31 a.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java, > > line 2723 > > <https://reviews.apache.org/r/44725/diff/4/?file=1310989#file1310989line2723> > > > > This is a great idea. I am suprised we haven't done this already. > > However, I don't see where this new filter class is being used, so how was > > the issue in the description addressed? > > Robert Nettleton wrote: > Hi Rob, the Blueprint export filters have been around for a while, check > out: > > > org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor#shouldPropertyBeExcludedForBlueprintExport > > Basically, this method iterates over the registered filters to determine > if a property should be excluded. > > Thanks.
Thnaks for the clarification Bob. Droppng my issue. - Robert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44725/#review125010 ----------------------------------------------------------- On March 22, 2016, 9:40 p.m., Amruta Borkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44725/ > ----------------------------------------------------------- > > (Updated March 22, 2016, 9:40 p.m.) > > > Review request for Ambari, Robert Levas and Robert Nettleton. > > > Bugs: AMBARI-15338 > https://issues.apache.org/jira/browse/AMBARI-15338 > > > Repository: ambari > > > Description > ------- > > After exporting blueprint from ranger enabled cluster > ranger.service.https.attrib.keystore.pass is exported. > Which needs to be removed before using the same blueprint to create another > cluster > Error Show when used same blueprint: > { "status" : 400, "message" : "Blueprint configuration validation failed: > Secret references are not allowed in blueprints, replace following properties > with real passwords:\n Config:ranger-admin-site > Property:ranger.service.https.attrib.keystore.pass\n" } > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java > 4230862 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java > 0f62b2c > > Diff: https://reviews.apache.org/r/44725/diff/ > > > Testing > ------- > > Modified test cases to test for if the properties that end with "pass" are > getting filtered. Other properties which have 'pass' else where in the name > will not get filtered. > > > Thanks, > > Amruta Borkar > >
