> On March 24, 2016, 11:41 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py, > > line 108 > > <https://reviews.apache.org/r/45325/diff/1/?file=1314430#file1314430line108> > > > > Can move fileExists inside the if.
I am not sure on this. Based on fileExists, the if is based on. > On March 24, 2016, 11:41 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py, > > line 46 > > <https://reviews.apache.org/r/45325/diff/1/?file=1314432#file1314432line46> > > > > Is this similar to hive batch? If so, can we share some of the code? Multiple varibales will have to passed to make it work. Can happen though. The time we merge both Hive1 and Hive2 won't hive any benefits. > On March 24, 2016, 11:41 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py, > > line 496 > > <https://reviews.apache.org/r/45325/diff/1/?file=1314433#file1314433line496> > > > > Should not rely on this, instead, use /etc/tez_hive/$version/0 or > > /usr/hdp/current/$name/conf Will open a bug to get work as suggested. As of now we dont have /usr/hdp/current/$name/conf for tez_hive2. > On March 24, 2016, 11:41 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py, > > line 116 > > <https://reviews.apache.org/r/45325/diff/1/?file=1314430#file1314430line116> > > > > Should not do sys.exit since may not grab error message, instead, > > return. Using return - Swapan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45325/#review125366 ----------------------------------------------------------- On March 24, 2016, 11:24 p.m., Swapan Shridhar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45325/ > ----------------------------------------------------------- > > (Updated March 24, 2016, 11:24 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit > Mohanty. > > > Bugs: AMBARI-15573 > https://issues.apache.org/jira/browse/AMBARI-15573 > > > Repository: ambari > > > Description > ------- > > Add the Config, Start and Stop logic for: (1). Hive Server Interactive (HSI), > and (2). Associate the LLAP lifecycle to it. > > - Start of HSI : Create LLAP package, start LLAP and then start HSI. > - Stop: Stop HSI and then LLAP. > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py > f07b76f > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py > 8a4e7e6 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py > 12cf336 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > 6f05fbc > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py > 62fc2e3 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/startHiveserver2Interactive.sh.j2 > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/tarball_map.json > 1e349a1 > > ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/hive-interactive-site.xml > face571 > > Diff: https://reviews.apache.org/r/45325/diff/ > > > Testing > ------- > > Yes. > - 2.6: Installation, config, Start and Stop of Hive Server Interactive after > Hive Server Batch -> Works. > - 2.6 : Instllation, config, Start and Stop of Hive Server Batch only -> > Works > - 2.6 : nstallation, config, Start and Stop of Hive Server Interactive along > with Hive Server Batch -> Works. > - 2.5 : Negative testing : Only Hive Batch gets installed. (Hive Server > Interactive not present). > - > - Python UT : Passes. > - mvn clean test : ongoing. Will update. > > > Thanks, > > Swapan Shridhar > >
