----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45325/#review125762 -----------------------------------------------------------
Fix it, then Ship it! ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py (line 107) <https://reviews.apache.org/r/45325/#comment188612> Why does this need to accept self? ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py (line 147) <https://reviews.apache.org/r/45325/#comment188613> Stylistically, better to always end with a "return False", and only return True in the success condition. ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py (line 155) <https://reviews.apache.org/r/45325/#comment188614> May want to enclose the content of finally inside its own try-except ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py (line 163) <https://reviews.apache.org/r/45325/#comment188615> Use LOG. - Alejandro Fernandez On March 27, 2016, 11:14 p.m., Swapan Shridhar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45325/ > ----------------------------------------------------------- > > (Updated March 27, 2016, 11:14 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit > Mohanty. > > > Bugs: AMBARI-15573 > https://issues.apache.org/jira/browse/AMBARI-15573 > > > Repository: ambari > > > Description > ------- > > Add the Config, Start and Stop logic for: (1). Hive Server Interactive (HSI), > and (2). Associate the LLAP lifecycle to it. > > - Start of HSI : Create LLAP package, start LLAP and then start HSI. > - Stop: Stop HSI and then LLAP. > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py > f07b76f > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py > 3532efc > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py > 8a4e7e6 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py > 12cf336 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > 6f05fbc > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py > a6e4a47 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/startHiveserver2Interactive.sh.j2 > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/tarball_map.json > 1e349a1 > > ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml > face571 > > Diff: https://reviews.apache.org/r/45325/diff/ > > > Testing > ------- > > Yes. > - 2.6: Installation, config, Start and Stop of Hive Server Interactive after > Hive Server Batch -> Works. > - 2.6 : Instllation, config, Start and Stop of Hive Server Batch only -> > Works > - 2.6 : nstallation, config, Start and Stop of Hive Server Interactive along > with Hive Server Batch -> Works. > - 2.5 : Negative testing : Only Hive Batch gets installed. (Hive Server > Interactive not present). > - > - Python UT : Passes. > - mvn clean test : ongoing. Will update. > > > Thanks, > > Swapan Shridhar > >