----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45998/#review129732 -----------------------------------------------------------
Ship it! ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py (lines 117 - 119) <https://reviews.apache.org/r/45998/#comment193281> Given how many things get passed to this script, why not do all this in python? Seems a whole lot of setup for a script file that we control anyway. We have plenty of knowledge around making curl calls and reading output etc. Food for thought; I'm not holding up the review for it. - Nate Cole On April 16, 2016, 3:02 p.m., Masahiro Tanaka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45998/ > ----------------------------------------------------------- > > (Updated April 16, 2016, 3:02 p.m.) > > > Review request for Ambari, Andrew Onischuk, Jaimin Jetly, and Nate Cole. > > > Repository: ambari > > > Description > ------- > > In templetonSmoke.sh, there are > 1) unnecessary `exit 0` > 2) lack of redirect `>` command > 3) unassigned variable > > we should correct them all to check the HIVE service properly. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh > dd00e02 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py > 9965bfa9 > ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py > 6c4dc00 > > Diff: https://reviews.apache.org/r/45998/diff/ > > > Testing > ------- > > mvn clean test and manual test with HDP2.4 and Ambari 2.2.1.0 > > > Thanks, > > Masahiro Tanaka > >