> On April 21, 2016, 12:25 a.m., Masahiro Tanaka wrote: > > Thanks for the review Nate and Andrew! > > Could you commit this?
before we can commit we need an apache jira for this change, and +1 from Hadoop QA. Do you have one? If yes specify its id in "Bugs" field here. - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45998/#review129845 ----------------------------------------------------------- On April 16, 2016, 7:02 p.m., Masahiro Tanaka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45998/ > ----------------------------------------------------------- > > (Updated April 16, 2016, 7:02 p.m.) > > > Review request for Ambari, Andrew Onischuk, Jaimin Jetly, and Nate Cole. > > > Repository: ambari > > > Description > ------- > > In templetonSmoke.sh, there are > 1) unnecessary `exit 0` > 2) lack of redirect `>` command > 3) unassigned variable > > we should correct them all to check the HIVE service properly. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh > dd00e02 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py > 9965bfa9 > ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py > 6c4dc00 > > Diff: https://reviews.apache.org/r/45998/diff/ > > > Testing > ------- > > mvn clean test and manual test with HDP2.4 and Ambari 2.2.1.0 > > > Thanks, > > Masahiro Tanaka > >
