----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46484/#review129888 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java (line 51) <https://reviews.apache.org/r/46484/#comment193436> Grammar: Cluster Health I don't think we want to indicate here that it needs to be re-run; running it again won't really help unless action is taken first. Let's keep this as a general description. ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java (line 54) <https://reviews.apache.org/r/46484/#comment193437> The following issues have been detected on this cluster and should be addressed before upgrading: ambari-server/src/main/java/org/apache/ambari/server/checks/HealthCheck.java (line 43) <https://reviews.apache.org/r/46484/#comment193438> Doc. ambari-server/src/main/java/org/apache/ambari/server/checks/HealthCheck.java (line 67) <https://reviews.apache.org/r/46484/#comment193439> This needs to be "current" alerts: `AlertsDAO.findCurrentByCluster()` This could potentially pull back 100,000 entries. ambari-server/src/main/java/org/apache/ambari/server/checks/HealthCheck.java (lines 72 - 75) <https://reviews.apache.org/r/46484/#comment193440> Let's do something better here; maybe add some formatting. Also - the text of the alert isn't necessary, just the definition label: "<state>: <definition-label>: <host>" The host may be null, so you'll need to account for that. Also, let's use a sorted set so that all CRITICALs and grouped and all WARNINGs are grouped. - Jonathan Hurley On April 21, 2016, 7:14 a.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46484/ > ----------------------------------------------------------- > > (Updated April 21, 2016, 7:14 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan > Hurley, and Nate Cole. > > > Bugs: AMBARI-16005 > https://issues.apache.org/jira/browse/AMBARI-16005 > > > Repository: ambari > > > Description > ------- > > Enhance Health Check for the Cluster before upgrading. > > * check for alerts (perhaps don't start RU/EU if any blocker alerts). > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java > 3e957b1 > > ambari-server/src/main/java/org/apache/ambari/server/checks/HealthCheck.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/checks/HealthCheckTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/46484/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Dmitro Lisnichenko > >
