----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46484/#review129890 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/checks/HealthCheck.java (lines 33 - 34) <https://reviews.apache.org/r/46484/#comment193441> I've usually seen imports ordered like so: import static first import java... import org... import com... ambari-server/src/main/java/org/apache/ambari/server/checks/HealthCheck.java (lines 71 - 82) <https://reviews.apache.org/r/46484/#comment193442> A check like this can use some formatted output. We can add any object to the getFailedDetail() that will get output as json. This give the UI the option to do something interesting with text. See for example ConfigurationMergeCheck. - Nate Cole On April 21, 2016, 7:14 a.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46484/ > ----------------------------------------------------------- > > (Updated April 21, 2016, 7:14 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan > Hurley, and Nate Cole. > > > Bugs: AMBARI-16005 > https://issues.apache.org/jira/browse/AMBARI-16005 > > > Repository: ambari > > > Description > ------- > > Enhance Health Check for the Cluster before upgrading. > > * check for alerts (perhaps don't start RU/EU if any blocker alerts). > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java > 3e957b1 > > ambari-server/src/main/java/org/apache/ambari/server/checks/HealthCheck.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/checks/HealthCheckTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/46484/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Dmitro Lisnichenko > >
