----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46742/#review130816 -----------------------------------------------------------
Please add unit tests. - Alexander Denissov On April 27, 2016, 5:29 p.m., Matt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46742/ > ----------------------------------------------------------- > > (Updated April 27, 2016, 5:29 p.m.) > > > Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam > Tadi, jun aoki, and Lav Jain. > > > Bugs: AMBARI-16106 > https://issues.apache.org/jira/browse/AMBARI-16106 > > > Repository: ambari > > > Description > ------- > > Make changes to HAWQ Check implementation based on HAWQ-668 > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py > 15ceaa2 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py > 76a5885 > > Diff: https://reviews.apache.org/r/46742/diff/ > > > Testing > ------- > > Manually tested > > Ran unit tests: > test_stop_default (test_hawqmaster.TestHawqMaster) ... ok > test_configure_default (test_hawqsegment.TestHawqSegment) ... ok > test_install_default (test_hawqsegment.TestHawqSegment) ... ok > test_start_default (test_hawqsegment.TestHawqSegment) ... ok > test_stop_default (test_hawqsegment.TestHawqSegment) ... ok > test_configure_default (test_hawqstandby.TestHawqStandby) ... ok > test_install_default (test_hawqstandby.TestHawqStandby) ... ok > test_start_default (test_hawqstandby.TestHawqStandby) ... ok > test_stop_default (test_hawqstandby.TestHawqStandby) ... ok > test_generate_hawq_process_status_cmd (test_utils.TestUtils) ... ok > > ---------------------------------------------------------------------- > Ran 35 tests in 0.126s > > OK > > > Thanks, > > Matt > >