----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46742/ -----------------------------------------------------------
(Updated April 28, 2016, 6:34 p.m.) Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam Tadi, jun aoki, and Lav Jain. Changes ------- Updated patch with unit tests Bugs: AMBARI-16106 https://issues.apache.org/jira/browse/AMBARI-16106 Repository: ambari Description ------- Make changes to HAWQ Check implementation based on HAWQ-668 Diffs (updated) ----- ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py 15ceaa2 ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py 76a5885 ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 03323df Diff: https://reviews.apache.org/r/46742/diff/ Testing (updated) ------- Manually tested. Added 15 unit tests. Ran unit tests: test_hawq_master_critical (test_alert_component_status.TestAlertComponentStatus) ... ok test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) ... ok test_hawq_segment_critical (test_alert_component_status.TestAlertComponentStatus) ... ok test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) ... ok test_hawq_standby_critical (test_alert_component_status.TestAlertComponentStatus) ... ok test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) ... ok test_missing_configs (test_alert_component_status.TestAlertComponentStatus) ... ok test_exception_registration_status (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No handlers could be found for logger "ambari_alerts" ok test_missing_configs (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok test_missing_slave_file (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok test_successful_registration_status (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok test_unsuccessful_empty_db_registration_status (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok test_unsuccessful_registration_status (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok test_unsuccessful_registration_status_plural (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok test_configure_default (test_hawqmaster.TestHawqMaster) ... ok test_install_default (test_hawqmaster.TestHawqMaster) ... ok test_remove_hawq_standby (test_hawqmaster.TestHawqMaster) Run custom command Remove HAWQ Standby ... 2016-04-28 18:33:41,376 - Removing HAWQ Standby Master ... ok test_resync_hawq_standby (test_hawqmaster.TestHawqMaster) Run custom command Resync HAWQ Standby ... 2016-04-28 18:33:41,380 - HAWQ Standby Master Re-Sync started in fast mode... ok test_run_hawq_check_case1 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 1: Non HDFS-HA, Standalone Resource Management, Not Kerberized ... 2016-04-28 18:33:41,384 - Executing HAWQ Check ... ok test_run_hawq_check_case10 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 10: HDFS-HA, YARN Resource Management Non YARN_HA, Kerberized ... 2016-04-28 18:33:41,392 - Executing HAWQ Check ... ok test_run_hawq_check_case11 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 11: HDFS-HA, YARN Resource Management YARN_HA, Not Kerberized ... 2016-04-28 18:33:41,401 - Executing HAWQ Check ... ok test_run_hawq_check_case12 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 12: HDFS-HA, YARN Resource Management YARN_HA, Kerberized ... 2016-04-28 18:33:41,408 - Executing HAWQ Check ... ok test_run_hawq_check_case2 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 2: Non HDFS-HA, Standalone Resource Management, Kerberized ... 2016-04-28 18:33:41,415 - Executing HAWQ Check ... ok test_run_hawq_check_case3 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 3: Non HDFS-HA, YARN Resource Management Non YARN_HA, Not Kerberized ... 2016-04-28 18:33:41,422 - Executing HAWQ Check ... ok test_run_hawq_check_case4 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 4: Non HDFS-HA, YARN Resource Management Non YARN_HA, Kerberized ... 2016-04-28 18:33:41,429 - Executing HAWQ Check ... ok test_run_hawq_check_case5 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 5: Non HDFS-HA, YARN Resource Management YARN_HA, Not Kerberized ... 2016-04-28 18:33:41,435 - Executing HAWQ Check ... ok test_run_hawq_check_case6 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 6: Non HDFS-HA, YARN Resource Management YARN_HA, Kerberized ... 2016-04-28 18:33:41,444 - Executing HAWQ Check ... ok test_run_hawq_check_case7 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 7: HDFS-HA, Standalone Resource Management, Not Kerberized ... 2016-04-28 18:33:41,451 - Executing HAWQ Check ... ok test_run_hawq_check_case8 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 8: HDFS-HA, Standalone Resource Management, Kerberized ... 2016-04-28 18:33:41,459 - Executing HAWQ Check ... ok test_run_hawq_check_case9 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 9: HDFS-HA, YARN Resource Management Non YARN_HA, Not Kerberized ... 2016-04-28 18:33:41,466 - Executing HAWQ Check ... ok test_start_default (test_hawqmaster.TestHawqMaster) ... 2016-04-28 18:33:41,473 - Skipping ssh key exchange with HAWQ hosts as hawq_ssh_exkeys is either set to false or is not available in hawq-env.xml ok test_stop_cluster_immediate (test_hawqmaster.TestHawqMaster) Run Stop HAWQ Cluster Immediate Mode ... ok test_stop_default (test_hawqmaster.TestHawqMaster) Run Stop HAWQMASTER ... ok test_configure_default (test_hawqsegment.TestHawqSegment) ... ok test_install_default (test_hawqsegment.TestHawqSegment) ... ok test_start_default (test_hawqsegment.TestHawqSegment) ... ok test_stop_default (test_hawqsegment.TestHawqSegment) ... ok test_configure_default (test_hawqstandby.TestHawqStandby) ... ok test_install_default (test_hawqstandby.TestHawqStandby) ... ok test_start_default (test_hawqstandby.TestHawqStandby) ... ok test_stop_default (test_hawqstandby.TestHawqStandby) ... ok test_generate_hawq_process_status_cmd (test_utils.TestUtils) ... ok ---------------------------------------------------------------------- Ran 50 tests in 0.347s OK Thanks, Matt