----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48741/#review137798 -----------------------------------------------------------
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logfeeder.py (line 52) <https://reviews.apache.org/r/48741/#comment202984> Do we need to do this? Because we are already doing it explicitly setting the configuration in the OutputSolr. Also letting the SolrClient do everything is better, because we have to ensure the tickets are renewed periodically. ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch.py (line 46) <https://reviews.apache.org/r/48741/#comment202985> Same comment as for LogFeeder. Do we need to do kinit in command line? ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py (line 138) <https://reviews.apache.org/r/48741/#comment202990> Ideally, we should just use our Hadoop wide HTTP spnego keytab and add group "hadoop" to logsearch solr user ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch_solr.py (line 82) <https://reviews.apache.org/r/48741/#comment202996> We should set explicit permission to this path. Only logsearch-solr-user, logsearch-user, ranger-user and atlas-user should have write permission. Essentially, in addition to logsearch-solr-user, only other who need to upload config into zookeeper should have write permission. I have also seen cases, where if we don't protect zookeeper path, then if knit'ed user accesses zookeeper, then it will fail. ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch_solr.py (line 86) <https://reviews.apache.org/r/48741/#comment202991> Just curious, what does params.user_groups do here? - Don Bosco Durai On June 15, 2016, 5:37 p.m., Oliver Szabo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48741/ > ----------------------------------------------------------- > > (Updated June 15, 2016, 5:37 p.m.) > > > Review request for Ambari, Don Bosco Durai, Miklos Gergely, Robert Levas, > Robert Nettleton, Sumit Mohanty, and Sebastian Toader. > > > Bugs: AMBARI-16736 > https://issues.apache.org/jira/browse/AMBARI-16736 > > > Repository: ambari > > > Description > ------- > > Basuc logsearch solr kerberos support. > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py > e0a30ed > ambari-logsearch/ambari-logsearch-logfeeder/pom.xml bbe0bc9 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java > b14c273 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/logfeeder.properties > 076c09c > ambari-logsearch/ambari-logsearch-portal/pom.xml e83c75b > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java > cd4ef93 > > ambari-logsearch/ambari-logsearch-portal/src/main/resources/logsearch.properties > 37c8317 > ambari-logsearch/ambari-logsearch-solr-client/pom.xml b634928 > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java > a2da737 > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.java > 2805b0b > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientBuilder.java > 0813221 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/alerts.json > 85762e0 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml > d27067c > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml > 3682e5d > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-env.xml > 2420be0 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/kerberos.json > 6dd4aa7 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logfeeder.py > ce7f71c > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch.py > 2b5fdf7 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch_common.py > d0ac389 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch_solr.py > b55f3d6 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py > 8a1449d > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py > 5d1ca85 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py > 368db03 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch_solr.py > eac60db > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/status_params.py > 1efe605 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logfeeder.properties.j2 > 6a52708 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logfeeder_jaas.conf.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logsearch.properties.j2 > 9ada5bf > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logsearch_jaas.conf.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logsearch_solr_jaas.conf.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/zoo.cfg.j2 > 1f3808b > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-solr-env.sh.j2 > 9f76d18 > ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_solr.py 7cbbfc4 > > Diff: https://reviews.apache.org/r/48741/diff/ > > > Testing > ------- > > ambari server python unit test output: > > Total run:1061 > Total errors:0 > Total failures:0 > > > Thanks, > > Oliver Szabo > >
