----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48741/#review137821 -----------------------------------------------------------
Ship it! ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml (line 135) <https://reviews.apache.org/r/48741/#comment203001> Is "none" an acceptable value here? Maybe this should be ""? ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml (line 142) <https://reviews.apache.org/r/48741/#comment203002> Is "none" an acceptable value here? Maybe this should be ""? ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml (line 171) <https://reviews.apache.org/r/48741/#comment203003> Is "none" an acceptable value here? Maybe this should be ""? ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml (line 178) <https://reviews.apache.org/r/48741/#comment203004> Is "none" an acceptable value here? Maybe this should be ""? ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-env.xml (line 192) <https://reviews.apache.org/r/48741/#comment203005> Is "none" an acceptable value here? Maybe this should be ""? ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-env.xml (line 200) <https://reviews.apache.org/r/48741/#comment203006> Is "none" an acceptable value here? Maybe this should be ""? ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-env.xml (line 208) <https://reviews.apache.org/r/48741/#comment203007> Is "none" an acceptable value here? Maybe this should be ""? ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-env.xml (line 216) <https://reviews.apache.org/r/48741/#comment203008> Is "none" an acceptable value here? Maybe this should be ""? - Robert Levas On June 15, 2016, 1:37 p.m., Oliver Szabo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48741/ > ----------------------------------------------------------- > > (Updated June 15, 2016, 1:37 p.m.) > > > Review request for Ambari, Don Bosco Durai, Miklos Gergely, Robert Levas, > Robert Nettleton, Sumit Mohanty, and Sebastian Toader. > > > Bugs: AMBARI-16736 > https://issues.apache.org/jira/browse/AMBARI-16736 > > > Repository: ambari > > > Description > ------- > > Basuc logsearch solr kerberos support. > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py > e0a30ed > ambari-logsearch/ambari-logsearch-logfeeder/pom.xml bbe0bc9 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java > b14c273 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/logfeeder.properties > 076c09c > ambari-logsearch/ambari-logsearch-portal/pom.xml e83c75b > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java > cd4ef93 > > ambari-logsearch/ambari-logsearch-portal/src/main/resources/logsearch.properties > 37c8317 > ambari-logsearch/ambari-logsearch-solr-client/pom.xml b634928 > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java > a2da737 > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.java > 2805b0b > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientBuilder.java > 0813221 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/alerts.json > 85762e0 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml > d27067c > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml > 3682e5d > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-env.xml > 2420be0 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/kerberos.json > 6dd4aa7 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logfeeder.py > ce7f71c > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch.py > 2b5fdf7 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch_common.py > d0ac389 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch_solr.py > b55f3d6 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py > 8a1449d > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py > 5d1ca85 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py > 368db03 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch_solr.py > eac60db > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/status_params.py > 1efe605 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logfeeder.properties.j2 > 6a52708 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logfeeder_jaas.conf.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logsearch.properties.j2 > 9ada5bf > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logsearch_jaas.conf.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logsearch_solr_jaas.conf.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/zoo.cfg.j2 > 1f3808b > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-solr-env.sh.j2 > 9f76d18 > ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_solr.py 7cbbfc4 > > Diff: https://reviews.apache.org/r/48741/diff/ > > > Testing > ------- > > ambari server python unit test output: > > Total run:1061 > Total errors:0 > Total failures:0 > > > Thanks, > > Oliver Szabo > >
