----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52842/#review153154 -----------------------------------------------------------
Ship it! Ship It! - Alejandro Fernandez On Oct. 18, 2016, 6:35 p.m., Aravindan Vijayan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52842/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2016, 6:35 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmytro Sen, Sumit Mohanty, > and Sid Wagle. > > > Bugs: AMBARI-18593 > https://issues.apache.org/jira/browse/AMBARI-18593 > > > Repository: ambari > > > Description > ------- > > HDFS exposes top user activity broken down by operations in jmx (nntop). > These metrics should be captured in AMS and exposed in Grafana's HDFS > dashboards. > > Downsampling should likely be a function like MIN, MAX, AVG, SUM of > underlying timeseries specified from the client. > > > Diffs > ----- > > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/AbstractTimelineAggregator.java > ba7807b > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/CustomDownSampler.java > PRE-CREATION > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/DownSamplerUtils.java > PRE-CREATION > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TopNDownSampler.java > PRE-CREATION > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/v2/TimelineMetricClusterAggregator.java > c056d79 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/v2/TimelineMetricHostAggregator.java > 118c695 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java > 177e444 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/TopNCondition.java > f7060e0 > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/DownSamplerTest.java > PRE-CREATION > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml > b6e5da9 > > Diff: https://reviews.apache.org/r/52842/diff/ > > > Testing > ------- > > Manually tested. > Unit tests added. > mvn clean test on ambari-metrics pending. > > > Thanks, > > Aravindan Vijayan > >
