> On Oct. 20, 2016, 2:01 a.m., Sid Wagle wrote: > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml, > > line 686 > > <https://reviews.apache.org/r/52842/diff/2/?file=1540795#file1540795line686> > > > > 1. Why %.user=% vs op=% ? > > 2. I was expecting op=% vs op=_%, is that special syntx? > > Aravindan Vijayan wrote: > 1. We don't want to include a metric like > dfs.NNTopUserOpCounts.windowMs=60000.op=getFileInfo.user=yarn and exclude a > summed up metric like dfs.NNTopUserOpCounts.windowMs=60000.op=* in our Top N > calculation. > 2. op=% allows op=* , whereas op=__* does not. The small yet reasonable > hitch is that an op name should have at least 2 characters in length.
In the first point, I meant "We want to include...", not "We don't want to include". - Aravindan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52842/#review153330 ----------------------------------------------------------- On Oct. 18, 2016, 6:35 p.m., Aravindan Vijayan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52842/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2016, 6:35 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmytro Sen, Sumit Mohanty, > and Sid Wagle. > > > Bugs: AMBARI-18593 > https://issues.apache.org/jira/browse/AMBARI-18593 > > > Repository: ambari > > > Description > ------- > > HDFS exposes top user activity broken down by operations in jmx (nntop). > These metrics should be captured in AMS and exposed in Grafana's HDFS > dashboards. > > Downsampling should likely be a function like MIN, MAX, AVG, SUM of > underlying timeseries specified from the client. > > > Diffs > ----- > > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/AbstractTimelineAggregator.java > ba7807b > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/CustomDownSampler.java > PRE-CREATION > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/DownSamplerUtils.java > PRE-CREATION > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TopNDownSampler.java > PRE-CREATION > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/v2/TimelineMetricClusterAggregator.java > c056d79 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/v2/TimelineMetricHostAggregator.java > 118c695 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java > 177e444 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/TopNCondition.java > f7060e0 > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/DownSamplerTest.java > PRE-CREATION > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml > b6e5da9 > > Diff: https://reviews.apache.org/r/52842/diff/ > > > Testing > ------- > > Manually tested. > Unit tests added. > mvn clean test on ambari-metrics pending. > > > Thanks, > > Aravindan Vijayan > >