> On Nov. 29, 2016, 1:19 p.m., Oliver Szabo wrote: > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py, > > line 132 > > <https://reviews.apache.org/r/54161/diff/1/?file=1571883#file1571883line132> > > > > I think stack advisor changes are missing. at least it would be nice if > > it reccommend us some configuration in case we do not have infra-solr > > Miklos Gergely wrote: > I don't see what could we recommend. Also the empty fields and the > notification for the missing properties will remind the user that they must > fill these fields with the external solr's ZK.
like we could not know the number of external solr instances, so the maximum number of shards should be high (like 100), and the actual value should be 1. - Oliver ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54161/#review157237 ----------------------------------------------------------- On Nov. 29, 2016, 1:36 p.m., Miklos Gergely wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54161/ > ----------------------------------------------------------- > > (Updated Nov. 29, 2016, 1:36 p.m.) > > > Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty. > > > Bugs: AMBARI-19012 > https://issues.apache.org/jira/browse/AMBARI-19012 > > > Repository: ambari > > > Description > ------- > > Users can install LogSearch now without zookkeper or solr, using an external > server instead. If AMBARI_INFRA is present then the user may choose to use > it, or an external solr. > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py > 8257022 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml > c5b9b4e > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml > 6d1cf38 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py > bdb0c10 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py > 021c167 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py > 6c1a936 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/output.config.json.j2 > ff43323 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logfeeder-env.sh.j2 > 2818708 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-env.sh.j2 > eb7306c > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/themes/theme.json > 0193689 > ambari-server/src/test/python/stacks/2.4/configs/default.json c3eba53 > ambari-web/app/data/HDP2/site_properties.js d61d4aa > > Diff: https://reviews.apache.org/r/54161/diff/ > > > Testing > ------- > > Tested on local cluster. > > > Thanks, > > Miklos Gergely > >
