> On Dec. 4, 2016, 12:19 p.m., Oliver Szabo wrote: > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml, > > line 185 > > <https://reviews.apache.org/r/54161/diff/4-5/?file=1571968#file1571968line185> > > > > maybe you could add an example in the description for the principal and > > the keytab (if they are empty by default) > > Oliver Szabo wrote: > one more thing, is this change needed fog logfeeder as well? (addding > these properties)
I've added separete logfeeder kerberos principal/keytab for external solr. The description is the same as for "normal" kerberos keytab/principal, I don't see why do we need an example of a file path. - Miklos ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54161/#review157921 ----------------------------------------------------------- On Dec. 5, 2016, 10:11 a.m., Miklos Gergely wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54161/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2016, 10:11 a.m.) > > > Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty. > > > Bugs: AMBARI-19012 > https://issues.apache.org/jira/browse/AMBARI-19012 > > > Repository: ambari > > > Description > ------- > > Users can install LogSearch now without zookkeper or solr, using an external > server instead. If AMBARI_INFRA is present then the user may choose to use > it, or an external solr. > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py > 8257022 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml > ee885e3 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml > c5b9b4e > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml > f69bd3c > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py > d086f9f > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py > 9582334 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py > 6c1a936 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logfeeder-env.sh.j2 > 2818708 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-env.sh.j2 > eb7306c > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/output.config.json.j2 > 062d636 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/themes/theme.json > 0193689 > ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py > 4f0a9d0 > ambari-server/src/test/python/stacks/2.4/configs/default.json a6e2478 > ambari-web/app/data/HDP2/site_properties.js 5b66506 > > Diff: https://reviews.apache.org/r/54161/diff/ > > > Testing > ------- > > Tested on local cluster. > > > Thanks, > > Miklos Gergely > >