> On Dec. 5, 2016, 3:53 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java, > > lines 137-145 > > <https://reviews.apache.org/r/53980/diff/1/?file=1568483#file1568483line137> > > > > All of these essentially do the same thing, right? Just with different > > properties. It would be better to write the method once and then loop over > > the properties in a structured way.
Updated in latest patch > On Dec. 5, 2016, 3:53 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py, > > lines 317-318 > > <https://reviews.apache.org/r/53980/diff/1/?file=1568484#file1568484line317> > > > > Just because it's supported doesn't mean that the property exists. Same > > goes for all of the other files below. Updated in latest patch - Mugdha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53980/#review158001 ----------------------------------------------------------- On Dec. 7, 2016, 7:36 p.m., Mugdha Varadkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53980/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2016, 7:36 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan > Hurley, Sumit Mohanty, and Velmurugan Periasamy. > > > Bugs: AMBARI-18945 > https://issues.apache.org/jira/browse/AMBARI-18945 > > > Repository: ambari > > > Description > ------- > > Need to add a provision for creating default repository with static name or > user provided name. > > This will help user to provided service name under Ranger supported plugins > config tab and can take dump of latest snapshot of all policies and use it > while recreating another/multiple clusters with same service name. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java > ac97987 > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py > 32e1510 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py > f47dc8f > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py > 64f67b9 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > 496102e > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py > 5635fe3 > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-security.xml > 91061d1 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py > 4cefbda > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/ranger-kms-security.xml > 95e653c > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py > c20bdde > > ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-security.xml > 983702f > > ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py > 4859534 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py > 4d42861 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/ranger-hbase-security.xml > 1deb9e5 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/ranger-hdfs-security.xml > cfd8a4f > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-security.xml > ce4074a > > ambari-server/src/main/resources/stacks/HDP/2.3/services/KNOX/configuration/ranger-knox-security.xml > 9bd1079 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/ranger-yarn-security.xml > 5f69962 > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > 3c34fc6 > > ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/ranger-atlas-security.xml > ea0a026 > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py > 57555ee > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java > d4f2e8b > ambari-server/src/test/python/stacks/2.0.6/configs/nn_eu.json a6ed6ce > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py > 4a77086 > ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py > f4538d7 > ambari-server/src/test/python/stacks/2.5/configs/ranger-kms-default.json > 05cb78a > ambari-server/src/test/python/stacks/2.5/configs/ranger-kms-secured.json > 7054e8f > ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py > 011a874 > > Diff: https://reviews.apache.org/r/53980/diff/ > > > Testing > ------- > > mvn -DskipPythonTests -Dtest=UpgradeCatalog250Test test > > ------------------------------------------------------- > T E S T S > ------------------------------------------------------- > OpenJDK 64-Bit Server VM warning: ignoring option MaxPermSize=512m; support > was removed in 8.0 > Running org.apache.ambari.server.upgrade.UpgradeCatalog250Test > Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.548 sec - > in org.apache.ambari.server.upgrade.UpgradeCatalog250Test > > Results : > > Tests run: 13, Failures: 0, Errors: 0, Skipped: 0 > > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 30.347 s > [INFO] Finished at: 2016-11-22T11:51:23+00:00 > [INFO] Final Memory: 63M/1107M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Mugdha Varadkar > >
