> On Dec. 8, 2016, 2:37 p.m., Jonathan Hurley wrote: > > One thing I'm not clear on is how this will affect an existing > > installation. Won't Ranger have a problem if you change the name of a repo > > on an already running cluster?
Reverting the logic > On Dec. 8, 2016, 2:37 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java, > > line 384 > > <https://reviews.apache.org/r/53980/diff/2/?file=1578949#file1578949line384> > > > > I don't think this can be null/empty - ever. Reverting the logic > On Dec. 8, 2016, 2:37 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py, > > lines 221-229 > > <https://reviews.apache.org/r/53980/diff/2/?file=1578967#file1578967line221> > > > > This is a lot of logic repeated over and over - can this be placed in a > > common function and just re-used in order to get the name of the repo? > > Similar to what you did in the upgrade? Reverting the logic > On Dec. 8, 2016, 2:37 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java, > > line 377 > > <https://reviews.apache.org/r/53980/diff/2/?file=1578949#file1578949line377> > > > > Doc. Reverting the logic > On Dec. 8, 2016, 2:37 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java, > > line 362 > > <https://reviews.apache.org/r/53980/diff/2/?file=1578949#file1578949line362> > > > > Doc. Reverting the logic - Mugdha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53980/#review158525 ----------------------------------------------------------- On Dec. 13, 2016, 12:40 p.m., Mugdha Varadkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53980/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2016, 12:40 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan > Hurley, Sumit Mohanty, and Velmurugan Periasamy. > > > Bugs: AMBARI-18945 > https://issues.apache.org/jira/browse/AMBARI-18945 > > > Repository: ambari > > > Description > ------- > > Need to add a provision for creating default repository with static name or > user provided name. > > This will help user to provided service name under Ranger supported plugins > config tab and can take dump of latest snapshot of all policies and use it > while recreating another/multiple clusters with same service name. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py > 32e1510 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py > f47dc8f > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py > d86e360 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > e9436c1 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py > 5635fe3 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py > 4cefbda > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py > c20bdde > > ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py > 4859534 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py > 1347864 > > Diff: https://reviews.apache.org/r/53980/diff/ > > > Testing > ------- > > mvn -DskipPythonTests -Dtest=UpgradeCatalog250Test test > > ------------------------------------------------------- > T E S T S > ------------------------------------------------------- > OpenJDK 64-Bit Server VM warning: ignoring option MaxPermSize=512m; support > was removed in 8.0 > Running org.apache.ambari.server.upgrade.UpgradeCatalog250Test > Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.548 sec - > in org.apache.ambari.server.upgrade.UpgradeCatalog250Test > > Results : > > Tests run: 13, Failures: 0, Errors: 0, Skipped: 0 > > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 30.347 s > [INFO] Finished at: 2016-11-22T11:51:23+00:00 > [INFO] Final Memory: 63M/1107M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Mugdha Varadkar > >
