> On Dec. 20, 2016, 2:49 p.m., Attila Doroszlai wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluator.java, > > line 149 > > <https://reviews.apache.org/r/54891/diff/1/?file=1589499#file1589499line149> > > > > `Link.getProperties()` is `@Nullable`.
Good catch! > On Dec. 20, 2016, 2:49 p.m., Attila Doroszlai wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluatorException.java, > > line 4 > > <https://reviews.apache.org/r/54891/diff/1/?file=1589500#file1589500line4> > > > > Wouldn't `IllegalArgumentException` be OK for the same purpose? In this case I wanted a checked exception. - Balázs Bence ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54891/#review159704 ----------------------------------------------------------- On Dec. 20, 2016, 12:20 p.m., Balázs Bence Sári wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54891/ > ----------------------------------------------------------- > > (Updated Dec. 20, 2016, 12:20 p.m.) > > > Review request for Ambari, Attila Magyar, Jayush Luniya, Laszlo Puskas, > Sandor Magyari, Sumit Mohanty, and Sebastian Toader. > > > Bugs: AMBARI-19244 > https://issues.apache.org/jira/browse/AMBARI-19244 > > > Repository: ambari > > > Description > ------- > > Profile evaluator is a class that takes a quick links profile as input and > can decide on the visibility of quicklinks based on the received profile. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Component.java > 7ef0259 > > ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfile.java > 1a1488b > > ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluator.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluatorException.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Service.java > 600872f > > ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/EvaluatorTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluatorTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/54891/diff/ > > > Testing > ------- > > Wrote new unit tests. Run the ambari-server test suite. Failures are > irrelevant. > > Failed tests: > DataStoreImplTest.testFind:524 expected:<class > DS_DataStoreImplTest$TestEntity_1> but was:<class > DS_DataStoreImplTest$TestSubEntity_1> > DataStoreImplTest.testRemove:473 expected:<class > DS_DataStoreImplTest$TestEntity_1> but was:<class > DS_DataStoreImplTest$TestSubEntity_1> > DataStoreImplTest.testStore_update:355 expected:<class > DS_DataStoreImplTest$TestEntity_1> but was:<class > DS_DataStoreImplTest$TestSubEntity_1> > DataStoreImplTest.testStore_update_longStringValue:424 > Expectation failure on verify: > DynamicEntity.set("DS_id", 99): expected: 1, actual: 0 > Tests in error: > KerberosCheckerTest.testCheckFailed » Unexpected exception, > expected<org.apac... > KerberosCheckerTest.testCheckPassed:62 » ClassCast class > sun.security.provider... > AmbariBasicAuthenticationFilterTest.testOnSuccessfulAuthentication:99 » > Linkage > > Tests run: 4136, Failures: 4, Errors: 3, Skipped: 31 > > > Thanks, > > Balázs Bence Sári > >
