----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54891/ -----------------------------------------------------------
(Updated Dec. 21, 2016, 6:43 p.m.) Review request for Ambari, Attila Magyar, Jayush Luniya, Laszlo Puskas, Sandor Magyari, Sumit Mohanty, and Sebastian Toader. Changes ------- Fixed review comments + renamed link properties to attributes on Sumit's request, removed unused import Bugs: AMBARI-19244 https://issues.apache.org/jira/browse/AMBARI-19244 Repository: ambari Description ------- Profile evaluator is a class that takes a quick links profile as input and can decide on the visibility of quicklinks based on the received profile. Diffs (updated) ----- ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java 72ad764 ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/AcceptAllFilter.java 5124241 ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Component.java 7ef0259 ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Filter.java 1711628 ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/PropertyFilter.java 7b5eba0 ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfile.java 1a1488b ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluator.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluatorException.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParser.java c1f3c86 ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Service.java 600872f ambari-server/src/test/java/org/apache/ambari/server/stack/QuickLinksConfigurationModuleTest.java 190e61b ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/EvaluatorTest.java PRE-CREATION ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluatorTest.java PRE-CREATION ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParserTest.java 0644027 ambari-server/src/test/resources/TestAmbaryServer.samples/dummy_common_services/HIVE/0.11.0.2.0.5.0/package/.hash 9550dab ambari-server/src/test/resources/TestAmbaryServer.samples/dummy_stack/HIVE/package/.hash 9550dab ambari-server/src/test/resources/child_quicklinks_with_properties.json 36cd4f3 ambari-server/src/test/resources/example_quicklinks_profile.json 028d011 ambari-server/src/test/resources/inconsistent_quicklinks_profile.json e5bc310 Diff: https://reviews.apache.org/r/54891/diff/ Testing ------- Wrote new unit tests. Run the ambari-server test suite. Failures are irrelevant. Failed tests: DataStoreImplTest.testFind:524 expected:<class DS_DataStoreImplTest$TestEntity_1> but was:<class DS_DataStoreImplTest$TestSubEntity_1> DataStoreImplTest.testRemove:473 expected:<class DS_DataStoreImplTest$TestEntity_1> but was:<class DS_DataStoreImplTest$TestSubEntity_1> DataStoreImplTest.testStore_update:355 expected:<class DS_DataStoreImplTest$TestEntity_1> but was:<class DS_DataStoreImplTest$TestSubEntity_1> DataStoreImplTest.testStore_update_longStringValue:424 Expectation failure on verify: DynamicEntity.set("DS_id", 99): expected: 1, actual: 0 Tests in error: KerberosCheckerTest.testCheckFailed » Unexpected exception, expected<org.apac... KerberosCheckerTest.testCheckPassed:62 » ClassCast class sun.security.provider... AmbariBasicAuthenticationFilterTest.testOnSuccessfulAuthentication:99 » Linkage Tests run: 4136, Failures: 4, Errors: 3, Skipped: 31 Thanks, Balázs Bence Sári