> On May 2, 2017, 10:10 a.m., Oliver Szabo wrote: > > Im feeling that is not really the right solution to put the whole code into > > a big try catch block. it wont fail with even syntactic errors.
Hi Oliver, This is basically done so as to start Ranger irrespective of zookeeper error which can come in check_znode, As the error can now be visible to the user this may not affect the Ranger service start at all. - Vishal ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58797/#review173577 ----------------------------------------------------------- On April 27, 2017, 3:51 p.m., Vishal Suvagia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58797/ > ----------------------------------------------------------- > > (Updated April 27, 2017, 3:51 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, Mugdha > Varadkar, Oliver Szabo, and Velmurugan Periasamy. > > > Bugs: AMBARI-20868 > https://issues.apache.org/jira/browse/AMBARI-20868 > > > Repository: ambari > > > Description > ------- > > Ranger Admin start fails when Ambari Infra or External Solr service is down,. > need to handle errors and ensure Ranger start works, despite solr service > being down. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py > e56a705 > > ambari-server/src/main/resources/common-services/RANGER/0.7.0/properties/ranger-solrconfig.xml.j2 > 34ce70d > > > Diff: https://reviews.apache.org/r/58797/diff/2/ > > > Testing > ------- > > Verified fresh install on Cent-OS 6. > > > Thanks, > > Vishal Suvagia > >