> On May 2, 2017, 2:50 p.m., Oliver Szabo wrote: > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py > > Lines 752 (patched) > > <https://reviews.apache.org/r/58797/diff/2/?file=1701458#file1701458line752> > > > > try to use "resource_management.core.exceptions.ExecutionFailed" to > > make sure that is not a syntax error or something else
sorry I mean like runtime errors (with invalid types etc.), not syntax errors. those should not be compiled, so tests would fail on those. - Oliver ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58797/#review173591 ----------------------------------------------------------- On April 27, 2017, 3:51 p.m., Vishal Suvagia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58797/ > ----------------------------------------------------------- > > (Updated April 27, 2017, 3:51 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, Mugdha > Varadkar, Oliver Szabo, and Velmurugan Periasamy. > > > Bugs: AMBARI-20868 > https://issues.apache.org/jira/browse/AMBARI-20868 > > > Repository: ambari > > > Description > ------- > > Ranger Admin start fails when Ambari Infra or External Solr service is down,. > need to handle errors and ensure Ranger start works, despite solr service > being down. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py > e56a705 > > ambari-server/src/main/resources/common-services/RANGER/0.7.0/properties/ranger-solrconfig.xml.j2 > 34ce70d > > > Diff: https://reviews.apache.org/r/58797/diff/2/ > > > Testing > ------- > > Verified fresh install on Cent-OS 6. > > > Thanks, > > Vishal Suvagia > >
