> On May 2, 2017, 6:22 p.m., Robert Nettleton wrote: > > ambari-web/app/controllers/wizard/step8_controller.js > > Lines 1925 (patched) > > <https://reviews.apache.org/r/58864/diff/1/?file=1703676#file1703676line1925> > > > > Similar to my last point, the default provision_action is always > > "INSTALL_AND_START", so this might not need to be set in the Blueprint. > > Amruta Borkar wrote: > Hello Robert, > Thank you for your input, I think exporting these properties would make > users aware of the options that are available to them. May be we can export > both properties with default values? "config_recommendation_strategy" : > "NEVER_APPLY" and "provision_action" : "INSTALL_AND_START"? > @Di could you please provide your input?
These two really are optional and mostly there just for the sake of giving users hints on what would happen if a user deploys a cluster with the bp exported. we should change config recommendation strategy to NEVER APPLY as I expect bp exported to contain a complete set of configurations. provision_action can remain as INSTALL_AND_START (doesn't hurt to have it). - Di ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58864/#review173615 ----------------------------------------------------------- On May 1, 2017, 9:06 p.m., Amruta Borkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58864/ > ----------------------------------------------------------- > > (Updated May 1, 2017, 9:06 p.m.) > > > Review request for Ambari, Di Li, Jaimin Jetly, Jayush Luniya, Robert > Nettleton, Sangeeta Ravindran, Sumit Mohanty, and Yusaku Sako. > > > Bugs: AMBARI-20698 > https://issues.apache.org/jira/browse/AMBARI-20698 > > > Repository: ambari > > > Description > ------- > > UI be able to export a blueprint when a user reaches the Deploy page and the > bp can be used to install a cluster later on. > This patch exports blueprint and template. Currently HostGroups are formed > only based on the component mapping. In this patch configGroups are not > addressed. ConfigGroup and other improvements will be addressed in next > revisions of this functionality. > > > Diffs > ----- > > ambari-web/app/controllers/wizard/step8_controller.js 4678d03a48 > ambari-web/app/messages.js 8f8d981af7 > ambari-web/app/templates/wizard/step8.hbs ac32710468 > > > Diff: https://reviews.apache.org/r/58864/diff/1/ > > > Testing > ------- > > Manual Testing done. I have attached blueprint.json and clustertemplate.json > files that are currently generated with this patch applied. > > > File Attachments > ---------------- > > exported_blueprint > > https://reviews.apache.org/media/uploaded/files/2017/04/28/897160b1-46d8-49d1-bc87-f14249718c26__exported_blueprint_.json > exported_clustertemplate > > https://reviews.apache.org/media/uploaded/files/2017/04/28/e53d037e-a77e-487e-ac08-ce754e4afc97__exported_clustertemplate.json > > > Thanks, > > Amruta Borkar > >
