> On May 11, 2017, 11:41 p.m., Alexandr Antonenko wrote: > > ambari-web/app/controllers/wizard/step8_controller.js > > Line 29 (original), 30 (patched) > > <https://reviews.apache.org/r/58864/diff/3/?file=1710936#file1710936line30> > > > > is it aimed to hit all off the wizards that we are currently using ? > > > > > > like > > > > /** > > * @type {boolean} > > */ > > isAddService: Em.computed.equal('content.controllerName', > > 'addServiceController'), > > > > /** > > * @type {boolean} > > */ > > isAddHost: Em.computed.equal('content.controllerName', > > 'addHostController'), > > > > /** > > * @type {boolean} > > */ > > isInstaller: Em.computed.equal('content.controllerName', > > 'installerController'), > > > > > > because I didn't saw any chekings regaring this in your code
Hello Alexandr, The 'Generate Blueprint' button should only show up on the last page in the cluster installation wizard. I am checking it with {{#unless App.router.clusterInstallCompleted}} in step8.hbs file. This way the button will not show up on addService wizard. - Amruta ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58864/#review174746 ----------------------------------------------------------- On May 11, 2017, 7:02 p.m., Amruta Borkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58864/ > ----------------------------------------------------------- > > (Updated May 11, 2017, 7:02 p.m.) > > > Review request for Ambari, Alexandr Antonenko, Di Li, Jaimin Jetly, Jayush > Luniya, Robert Nettleton, Sangeeta Ravindran, Sumit Mohanty, and Yusaku Sako. > > > Bugs: AMBARI-20698 > https://issues.apache.org/jira/browse/AMBARI-20698 > > > Repository: ambari > > > Description > ------- > > UI be able to export a blueprint when a user reaches the Deploy page and the > bp can be used to install a cluster later on. > This patch exports blueprint and template. Currently HostGroups are formed > only based on the component mapping. In this patch configGroups are not > addressed. ConfigGroup and other improvements will be addressed in next > revisions of this functionality. > > > Diffs > ----- > > ambari-web/app/controllers/wizard/step8_controller.js 4678d03a48 > ambari-web/app/messages.js 8f8d981af7 > ambari-web/app/templates/wizard/step8.hbs ac32710468 > ambari-web/test/controllers/wizard/step8_test.js 7cdb69ab34 > > > Diff: https://reviews.apache.org/r/58864/diff/3/ > > > Testing > ------- > > Manual Testing done. I have attached blueprint.json and clustertemplate.json > files that are currently generated with this patch applied. > > > File Attachments > ---------------- > > exported_blueprint > > https://reviews.apache.org/media/uploaded/files/2017/04/28/897160b1-46d8-49d1-bc87-f14249718c26__exported_blueprint_.json > exported_clustertemplate > > https://reviews.apache.org/media/uploaded/files/2017/04/28/e53d037e-a77e-487e-ac08-ce754e4afc97__exported_clustertemplate.json > > > Thanks, > > Amruta Borkar > >