----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60430/#review178887 -----------------------------------------------------------
Ship it! Ship It! - Andrii Tkach On June 26, 2017, 1:13 p.m., Andrii Babiichuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60430/ > ----------------------------------------------------------- > > (Updated June 26, 2017, 1:13 p.m.) > > > Review request for Ambari and Andrii Tkach. > > > Bugs: AMBARI-21342 > https://issues.apache.org/jira/browse/AMBARI-21342 > > > Repository: ambari > > > Description > ------- > > Building Log Search UI with ```prod``` flag fails with lots of errors thrown: > ``` > Property '***' is private and only accessible within class '***' > ``` > > > Diffs > ----- > > > ambari-logsearch/ambari-logsearch-web-new/src/app/accordion-panel/accordion-panel.component.html > b2ce3a0 > > ambari-logsearch/ambari-logsearch-web-new/src/app/accordion-panel/accordion-panel.component.less > 8366952 > > ambari-logsearch/ambari-logsearch-web-new/src/app/accordion-panel/accordion-panel.component.spec.ts > 3706d51 > > ambari-logsearch/ambari-logsearch-web-new/src/app/accordion-panel/accordion-panel.component.ts > e48349e > ambari-logsearch/ambari-logsearch-web-new/src/app/app.component.html > 267e08b > ambari-logsearch/ambari-logsearch-web-new/src/app/app.component.less > f948b12 > ambari-logsearch/ambari-logsearch-web-new/src/app/app.component.spec.ts > 96cb0b4 > ambari-logsearch/ambari-logsearch-web-new/src/app/app.component.ts e86a8a1 > ambari-logsearch/ambari-logsearch-web-new/src/app/app.module.ts 6670082 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/accordion-panel/accordion-panel.component.html > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/accordion-panel/accordion-panel.component.less > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/accordion-panel/accordion-panel.component.spec.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/accordion-panel/accordion-panel.component.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/app.component.html > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/app.component.less > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/app.component.spec.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/app.component.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-list/dropdown-list.component.html > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-list/dropdown-list.component.less > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-list/dropdown-list.component.spec.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-list/dropdown-list.component.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-dropdown/filter-dropdown.component.html > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-dropdown/filter-dropdown.component.less > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-dropdown/filter-dropdown.component.spec.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-dropdown/filter-dropdown.component.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-text-field/filter-text-field.component.html > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-text-field/filter-text-field.component.less > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-text-field/filter-text-field.component.spec.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-text-field/filter-text-field.component.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/filters-panel/filters-panel.component.html > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/filters-panel/filters-panel.component.less > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/filters-panel/filters-panel.component.spec.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/filters-panel/filters-panel.component.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/login-form/login-form.component.html > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/login-form/login-form.component.less > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/login-form/login-form.component.spec.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/login-form/login-form.component.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-list/logs-list.component.html > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-list/logs-list.component.less > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-list/logs-list.component.spec.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-list/logs-list.component.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/main-container/main-container.component.html > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/main-container/main-container.component.spec.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/main-container/main-container.component.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/menu-button/menu-button.component.html > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/menu-button/menu-button.component.less > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/menu-button/menu-button.component.spec.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/menu-button/menu-button.component.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/top-menu/top-menu.component.html > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/top-menu/top-menu.component.less > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/top-menu/top-menu.component.spec.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/top-menu/top-menu.component.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web-new/src/app/components/variables.less > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/dropdown-list/dropdown-list.component.html > db4ee79 > > ambari-logsearch/ambari-logsearch-web-new/src/app/dropdown-list/dropdown-list.component.less > d0f079a > > ambari-logsearch/ambari-logsearch-web-new/src/app/dropdown-list/dropdown-list.component.spec.ts > 445ee97 > > ambari-logsearch/ambari-logsearch-web-new/src/app/dropdown-list/dropdown-list.component.ts > 808fcf8 > > ambari-logsearch/ambari-logsearch-web-new/src/app/filter-dropdown/filter-dropdown.component.html > 1ac663e > > ambari-logsearch/ambari-logsearch-web-new/src/app/filter-dropdown/filter-dropdown.component.less > ec8e84b > > ambari-logsearch/ambari-logsearch-web-new/src/app/filter-dropdown/filter-dropdown.component.spec.ts > e0414f3 > > ambari-logsearch/ambari-logsearch-web-new/src/app/filter-dropdown/filter-dropdown.component.ts > faaafcb > > ambari-logsearch/ambari-logsearch-web-new/src/app/filter-text-field/filter-text-field.component.html > ed3c4ba > > ambari-logsearch/ambari-logsearch-web-new/src/app/filter-text-field/filter-text-field.component.less > 1395959 > > ambari-logsearch/ambari-logsearch-web-new/src/app/filter-text-field/filter-text-field.component.spec.ts > e4f026c > > ambari-logsearch/ambari-logsearch-web-new/src/app/filter-text-field/filter-text-field.component.ts > 3f23ffd > > ambari-logsearch/ambari-logsearch-web-new/src/app/filters-panel/filters-panel.component.html > 6387c22 > > ambari-logsearch/ambari-logsearch-web-new/src/app/filters-panel/filters-panel.component.less > 46a157c > > ambari-logsearch/ambari-logsearch-web-new/src/app/filters-panel/filters-panel.component.spec.ts > 934f37a > > ambari-logsearch/ambari-logsearch-web-new/src/app/filters-panel/filters-panel.component.ts > 8c986f4 > > ambari-logsearch/ambari-logsearch-web-new/src/app/login-form/login-form.component.html > 37a96e9 > > ambari-logsearch/ambari-logsearch-web-new/src/app/login-form/login-form.component.less > f760ee8 > > ambari-logsearch/ambari-logsearch-web-new/src/app/login-form/login-form.component.spec.ts > 0498ee4 > > ambari-logsearch/ambari-logsearch-web-new/src/app/login-form/login-form.component.ts > 2a93775 > > ambari-logsearch/ambari-logsearch-web-new/src/app/logs-list/logs-list.component.html > 827f63c > > ambari-logsearch/ambari-logsearch-web-new/src/app/logs-list/logs-list.component.less > 6ed0463 > > ambari-logsearch/ambari-logsearch-web-new/src/app/logs-list/logs-list.component.spec.ts > 072bfcd > > ambari-logsearch/ambari-logsearch-web-new/src/app/logs-list/logs-list.component.ts > 6bc5ab9 > > ambari-logsearch/ambari-logsearch-web-new/src/app/main-container/main-container.component.html > 61562d2 > > ambari-logsearch/ambari-logsearch-web-new/src/app/main-container/main-container.component.spec.ts > 536f1ef > > ambari-logsearch/ambari-logsearch-web-new/src/app/main-container/main-container.component.ts > d2e6a7f > > ambari-logsearch/ambari-logsearch-web-new/src/app/menu-button/menu-button.component.html > 132d717 > > ambari-logsearch/ambari-logsearch-web-new/src/app/menu-button/menu-button.component.less > 6a3a43d > > ambari-logsearch/ambari-logsearch-web-new/src/app/menu-button/menu-button.component.spec.ts > 424d322 > > ambari-logsearch/ambari-logsearch-web-new/src/app/menu-button/menu-button.component.ts > ded01b7 > > ambari-logsearch/ambari-logsearch-web-new/src/app/top-menu/top-menu.component.html > 6898354 > > ambari-logsearch/ambari-logsearch-web-new/src/app/top-menu/top-menu.component.less > e5e85f4 > > ambari-logsearch/ambari-logsearch-web-new/src/app/top-menu/top-menu.component.spec.ts > 1649a50 > > ambari-logsearch/ambari-logsearch-web-new/src/app/top-menu/top-menu.component.ts > 73b6131 > ambari-logsearch/ambari-logsearch-web-new/src/app/variables.less 9a8ea09 > > > Diff: https://reviews.apache.org/r/60430/diff/1/ > > > Testing > ------- > > Executed 49 of 49 SUCCESS (1.754 secs / 1.722 secs) > > > Thanks, > > Andrii Babiichuk > >