----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53831/#review156207 -----------------------------------------------------------
Ship it! other than style nits, looks good to me! src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java (line 242) <https://reviews.apache.org/r/53831/#comment226367> All TODOs should be owned. Either change this to: `TODO(rdevalle): ...` or drop it. src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java (line 243) <https://reviews.apache.org/r/53831/#comment226369> style nit: one arg per line for continuations. src/test/java/org/apache/aurora/scheduler/resources/ResourceManagerTest.java (line 181) <https://reviews.apache.org/r/53831/#comment226368> kill blank line - Joshua Cohen On Nov. 17, 2016, 4:05 a.m., Renan DelValle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53831/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2016, 4:05 a.m.) > > > Review request for Aurora, David McLaughlin, Joshua Cohen, and Zameer Manji. > > > Repository: aurora > > > Description > ------- > > Placed filter when creating resource bags from Mesos resources in to avoid > trying to conver unsupported resources which leads to the scheduler crashing. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java > caacc583b552d0638ad59b9d69f7eee668b53723 > src/main/java/org/apache/aurora/scheduler/resources/ResourceType.java > 915c83d00c974bef36b42b7dd211dc16744f6c08 > > src/test/java/org/apache/aurora/scheduler/resources/ResourceManagerTest.java > 14ac54713acf69fc40807b8cf7345b7a043e1ad9 > > Diff: https://reviews.apache.org/r/53831/diff/ > > > Testing > ------- > > ./build-support/jenkins/build.sh > > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > > End to end testing finally passed after trying it 2 times, failures seem to > be unrelated to this patch. > > > Thanks, > > Renan DelValle > >
